Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 192973002: Add a GPU rasterization hint to cc::PictureLayer (Closed)

Created:
6 years, 9 months ago by ajuma
Modified:
6 years, 9 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, ernstm, Vangelis Kokkevis, nduca, alokp
Visibility:
Public.

Description

Add a GPU rasterization hint to cc::PictureLayer This adds a GPU rasterization hint to PictureLayer and PictureLayerImpl. When using hybrid rasterization (that is, when running with --enable-gpu-rasterization), only layers with a GPU rasterization hint are rasterized on the GPU. BUG=329722 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256304

Patch Set 1 : #

Patch Set 2 : Move hint to PictureLayer/WebContentLayer #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -38 lines) Patch
M cc/cc_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/picture_layer.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M cc/layers/picture_layer.cc View 3 chunks +16 lines, -6 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 3 chunks +4 lines, -8 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 8 chunks +26 lines, -14 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 4 chunks +71 lines, -10 lines 0 comments Download
A cc/test/gpu_rasterization_settings.h View 1 chunk +22 lines, -0 lines 0 comments Download
A cc/test/hybrid_rasterization_settings.h View 1 chunk +22 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 1 chunk +112 lines, -0 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_content_layer_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_content_layer_impl.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ajuma
This is split off from http://crrev.com/181063022, and depends on http://crrev.com/189883009 (that is, on the other ...
6 years, 9 months ago (2014-03-10 17:50:48 UTC) #1
enne (OOO)
Does this have to be on Layer? Can this be on WebContentLayerImpl/PictureLayer?
6 years, 9 months ago (2014-03-10 21:47:59 UTC) #2
ajuma
On 2014/03/10 21:47:59, enne wrote: > Does this have to be on Layer? Can this ...
6 years, 9 months ago (2014-03-10 23:37:58 UTC) #3
enne (OOO)
lgtm, thanks.
6 years, 9 months ago (2014-03-10 23:45:49 UTC) #4
ajuma
The CQ bit was checked by ajuma@chromium.org
6 years, 9 months ago (2014-03-11 16:01:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/192973002/50001
6 years, 9 months ago (2014-03-11 16:03:03 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 20:43:01 UTC) #7
Message was sent while issue was closed.
Change committed as 256304

Powered by Google App Engine
This is Rietveld 408576698