blimp/client/feature/navigation_feature.h - Issue 1929723002: [Blimp] Adds blimp engine browser test framework and LoadUrl test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/feature/navigation_feature.h

Issue 1929723002: [Blimp] Adds blimp engine browser test framework and LoadUrl test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/feature/mock_render_widget_feature_delegate.cc ('k') | blimp/client/feature/navigation_feature_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/feature/navigation_feature.h

diff --git a/blimp/client/feature/navigation_feature.h b/blimp/client/feature/navigation_feature.h

index 224764cd87beca74b6359ab23cfa442d20b8bfd0..751b872f486ebb3a8e316ea773bf1a86722c334a 100644

--- a/blimp/client/feature/navigation_feature.h

+++ b/blimp/client/feature/navigation_feature.h

@@ -27,6 +27,7 @@ class NavigationFeature : public BlimpMessageProcessor {

// a particular tab.

class NavigationFeatureDelegate {

public:

+ virtual ~NavigationFeatureDelegate() {}

virtual void OnUrlChanged(int tab_id, const GURL& url) = 0;

virtual void OnFaviconChanged(int tab_id, const SkBitmap& favicon) = 0;

virtual void OnTitleChanged(int tab_id, const std::string& title) = 0;

« no previous file with comments | « blimp/client/feature/mock_render_widget_feature_delegate.cc ('k') | blimp/client/feature/navigation_feature_unittest.cc » ('j') | no next file with comments »