blimp/engine/session/blimp_engine_session.h - Issue 1929723002: [Blimp] Adds blimp engine browser test framework and LoadUrl test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/session/blimp_engine_session.h

Issue 1929723002: [Blimp] Adds blimp engine browser test framework and LoadUrl test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Kevin's comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/engine/app/blimp_engine_config.cc ('K') | « blimp/engine/app/test_content_main_delegate.cc ('k') | blimp/engine/session/blimp_engine_session.cc » ('j') | blimp/test/browser_tests/blimp_browser_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/engine/session/blimp_engine_session.h

diff --git a/blimp/engine/session/blimp_engine_session.h b/blimp/engine/session/blimp_engine_session.h

index a78bb664c4b7a560cf1ca9a07c75f8b76be33b11..03d3e6bf973bc0cf4e63b809655d2b2adb025537 100644

--- a/blimp/engine/session/blimp_engine_session.h

+++ b/blimp/engine/session/blimp_engine_session.h

@@ -67,6 +67,8 @@ class BlimpScreen;

class BlimpWindowTreeHost;

class EngineNetworkComponents;

+using GetPortCallback = base::Callback<void(uint16_t)>;

Kevin M 2016/05/05 22:52:54 nit: make this a public member of BlimpEngineSessi

haibinlu 2016/05/05 23:39:25 Done.

class BlimpEngineSession

: public BlimpMessageProcessor,

public content::WebContentsDelegate,

@@ -87,6 +89,9 @@ class BlimpEngineSession

BlimpBrowserContext* browser_context() { return browser_context_.get(); }

+ // Gets Engine's listening port. Invokes callback with the allocated port.

+ void GetEnginePortForTesting(const GetPortCallback& callback);

// BlimpMessageProcessor implementation.

// This object handles incoming TAB_CONTROL and NAVIGATION messages directly.

void ProcessMessage(std::unique_ptr<BlimpMessage> message,