Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: blimp/engine/app/blimp_engine_config.cc

Issue 1929723002: [Blimp] Adds blimp engine browser test framework and LoadUrl test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses mmenke's comments. Client uses assignment directly without reading commandline. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/app/blimp_engine_config.cc
diff --git a/blimp/engine/app/blimp_engine_config.cc b/blimp/engine/app/blimp_engine_config.cc
index ccbdc4e52ffbd9a6d007b50382dc0945f2a10f53..d40985d3d85be23483a193cba90a3dd750fd9659 100644
--- a/blimp/engine/app/blimp_engine_config.cc
+++ b/blimp/engine/app/blimp_engine_config.cc
@@ -7,12 +7,17 @@
#include <memory>
#include <string>
+#include "base/base_switches.h"
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/memory/ptr_util.h"
#include "base/strings/string_util.h"
#include "blimp/engine/app/switches.h"
+#include "cc/base/switches.h"
+#include "content/public/common/content_switches.h"
+#include "ui/gl/gl_switches.h"
+#include "ui/native_theme/native_theme_switches.h"
namespace blimp {
namespace engine {
@@ -31,6 +36,18 @@ std::string GetClientToken(const base::CommandLine& cmd_line) {
}
} // namespace
+void SetUpCommandLine(base::CommandLine* command_line) {
+ command_line->AppendSwitch(::switches::kEnableOverlayScrollbar);
+ command_line->AppendSwitch(cc::switches::kDisableCachedPictureRaster);
+ command_line->AppendSwitch(::switches::kDisableGpu);
+ command_line->AppendSwitch(
+ "disable-remote-fonts"); // switches::kDisableRemoteFonts is not visible.
+ command_line->AppendSwitch(::switches::kUseRemoteCompositing);
+ command_line->AppendSwitchASCII(
+ ::switches::kUseGL,
+ "osmesa"); // Avoid invoking gpu::CollectDriverVersionNVidia.
+}
+
BlimpEngineConfig::~BlimpEngineConfig() {}
// static

Powered by Google App Engine
This is Rietveld 408576698