blimp/engine/app/blimp_content_main_delegate.h - Issue 1929723002: [Blimp] Adds blimp engine browser test framework and LoadUrl test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/app/blimp_content_main_delegate.h

Issue 1929723002: [Blimp] Adds blimp engine browser test framework and LoadUrl test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses mmenke's comments. Client uses assignment directly without reading commandline. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/engine/app/blimp_content_main_delegate.h

diff --git a/blimp/engine/app/blimp_content_main_delegate.h b/blimp/engine/app/blimp_content_main_delegate.h

index bc7876fc2f78d5f1eb007c7f758dd1a61a532735..22eaad58db29d64f10e8c5a7aabfacd961cdc016 100644

--- a/blimp/engine/app/blimp_content_main_delegate.h

+++ b/blimp/engine/app/blimp_content_main_delegate.h

@@ -22,12 +22,16 @@ class BlimpContentMainDelegate : public content::ContentMainDelegate {

BlimpContentMainDelegate();

~BlimpContentMainDelegate() override;

+ BlimpContentBrowserClient* GetBlimpContentBrowserClient();

Kevin M 2016/05/05 20:28:51 This is a simple getter, so how about "browser_cli

haibinlu 2016/05/05 22:41:36 Done.

// content::ContentMainDelegate implementation.

bool BasicStartupComplete(int* exit_code) override;

void PreSandboxStartup() override;

content::ContentBrowserClient* CreateContentBrowserClient() override;

content::ContentRendererClient* CreateContentRendererClient() override;

+ static BlimpContentMainDelegate* GetInstanceForTesting();

private:

void InitializeResourceBundle();

« blimp/client/BUILD.gn ('K') | « blimp/engine/app/blimp_content_browser_client.h ('k') | blimp/engine/app/blimp_content_main_delegate.cc » ('j') | no next file with comments »