blimp/client/app/android/toolbar.h - Issue 1929723002: [Blimp] Adds blimp engine browser test framework and LoadUrl test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/app/android/toolbar.h

Issue 1929723002: [Blimp] Adds blimp engine browser test framework and LoadUrl test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses mmenke's comments. Client uses assignment directly without reading commandline. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/client/app/android/toolbar.h

diff --git a/blimp/client/app/android/toolbar.h b/blimp/client/app/android/toolbar.h

index dc42d5fe5ebe283078ee5b2a55e73b070716fac3..000ed84efe3b41dcb92fec48b10aaa6b8c3ae454 100644

--- a/blimp/client/app/android/toolbar.h

+++ b/blimp/client/app/android/toolbar.h

@@ -48,7 +48,7 @@ class Toolbar : public NavigationFeature::NavigationFeatureDelegate {

void OnPageLoadStatusUpdate(int tab_id, bool completed) override;

private:

- virtual ~Toolbar();

+ ~Toolbar() override;

// A bridge to the network layer which does the work of (de)serializing the

// outgoing and incoming navigation messages from the engine. Toolbar does not

« blimp/client/BUILD.gn ('K') | « blimp/client/BUILD.gn ('k') | blimp/client/app/android/web_input_box.h » ('j') | blimp/engine/app/blimp_content_main_delegate.h » ('J')