[Blimp] Adds blimp engine browser test framework and LoadUrl test.

blimp/client/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 
 if (is_android) {
   import("//build/config/android/config.gni")
   import("//build/config/android/rules.gni")
 }
 
-source_set("client") {
+source_set("session") {
   sources = [
-    "app/blimp_client_switches.cc",
-    "app/blimp_client_switches.h",
-    "app/blimp_discardable_memory_allocator.cc",
-    "app/blimp_discardable_memory_allocator.h",
-    "app/blimp_startup.cc",
-    "app/blimp_startup.h",
     "session/assignment_source.cc",
     "session/assignment_source.h",
     "session/blimp_client_session.cc",
     "session/blimp_client_session.h",
   ]
 
   public_deps = [
+    "//components/safe_json",
+    "//ui/events",
+  ]
+
+  deps = [
+    ":feature",

[Kevin M, 2016/05/02 21:32:39]

Why is this needed?

[haibinlu, 2016/05/03 19:32:42]

blimp_client_session.cc has
   #include "blimp/client/feature/ime_feature.h"

"gn check out/NoX11 //blimp/*" requires it.

[Kevin M, 2016/05/03 20:29:34]

Acknowledged.

+    ":switches",
+    "//base",
+    "//blimp/common",
+    "//blimp/common/proto",
+    "//blimp/net",
+    "//net",
+    "//ui/gfx/geometry",
+    "//url:url",
+  ]
+}
+
+source_set("client") {
+  sources = [
+    "app/blimp_discardable_memory_allocator.cc",
+    "app/blimp_discardable_memory_allocator.h",
+    "app/blimp_startup.cc",
+    "app/blimp_startup.h",
+  ]
+
+  public_deps = [
     "//components/safe_json",
     "//components/url_formatter",
     "//ui/events",
   ]
 
   deps = [
     ":feature",

[Kevin M, 2016/05/02 21:32:39]

Not needed

[haibinlu, 2016/05/03 19:32:43]

Done.

+    ":feature_compositor",
+    ":session",
+    ":switches",
     "//base",
     "//blimp/common",
     "//blimp/common/proto",
     "//blimp/net",
     "//cc",
     "//gpu/command_buffer/client:gles2_implementation",
     "//gpu/skia_bindings",
     "//net",
     "//third_party/libwebp",
     "//ui/gfx/geometry",
     "//ui/gl",
     "//url:url",
   ]
 }
 
+source_set("switches") {
+  sources = [
+    "app/blimp_client_switches.cc",
+    "app/blimp_client_switches.h",
+  ]
+}
+
 source_set("blimp_client_unit_tests") {
   testonly = true
 
   sources = []
 
   deps = [
     ":client",
+    ":session",
+    ":switches",
     "//base",
     "//base/test:run_all_unittests",
     "//base/test:test_support",
     "//blimp/common",
     "//testing/gmock",
     "//testing/gtest",
   ]
 
   data = []
 
@@ skipping 21 matching lines @@
     "//base",
     "//base/test:run_all_unittests",
     "//base/test:test_support",
     "//testing/gmock",
     "//testing/gtest",
   ]
 }
 
 source_set("feature") {
   sources = [
+    "feature/ime_feature.cc",
+    "feature/ime_feature.h",
+    "feature/navigation_feature.cc",
+    "feature/navigation_feature.h",
+    "feature/render_widget_feature.cc",
+    "feature/render_widget_feature.h",
+    "feature/settings_feature.cc",
+    "feature/settings_feature.h",
+    "feature/tab_control_feature.cc",
+    "feature/tab_control_feature.h",
+  ]
+
+  deps = [
+    "//base:base",
+    "//blimp/common",
+    "//blimp/net",
+    "//cc",
+    "//cc/proto",
+    "//components/url_formatter",
+    "//net:net",
+    "//skia",
+    "//ui/base/ime:text_input_types",
+    "//ui/gfx/geometry:geometry",
+  ]
+
+  public_deps = [
+    "//blimp/common/proto",
+  ]
+}
+
+source_set("feature_compositor") {

[Kevin M, 2016/05/02 21:32:39]

Why this name? Is this a capital-F Feature in the Blimp sense?

[haibinlu, 2016/05/03 19:32:42]

Tommy suggested the name. 

What is the gn naming convention?

[Kevin M, 2016/05/03 20:29:34]

It's not that it's a bad name for GN, I just think it's a misleading prefix
because it doesn't reference any source files that fit the Blimp definition of a
feature.

I really think we should choose a different name, e.g. simply "compositor". I
don't think that the fact that they're nested under "feature" requires that we
expose that detail in the GN rule name.

[haibinlu, 2016/05/03 20:51:59]

Done.

+  sources = [
     "feature/compositor/blimp_compositor.cc",
     "feature/compositor/blimp_compositor.h",
     "feature/compositor/blimp_compositor_manager.cc",
     "feature/compositor/blimp_compositor_manager.h",
     "feature/compositor/blimp_context_provider.cc",
     "feature/compositor/blimp_context_provider.h",
     "feature/compositor/blimp_gpu_memory_buffer_manager.cc",
     "feature/compositor/blimp_gpu_memory_buffer_manager.h",
     "feature/compositor/blimp_input_handler_wrapper.cc",
     "feature/compositor/blimp_input_handler_wrapper.h",
     "feature/compositor/blimp_input_manager.cc",
     "feature/compositor/blimp_input_manager.h",
     "feature/compositor/blimp_layer_tree_settings.cc",
     "feature/compositor/blimp_layer_tree_settings.h",
     "feature/compositor/blimp_output_surface.cc",
     "feature/compositor/blimp_output_surface.h",
     "feature/compositor/decoding_image_generator.cc",
     "feature/compositor/decoding_image_generator.h",
-    "feature/ime_feature.cc",
-    "feature/ime_feature.h",
-    "feature/navigation_feature.cc",
-    "feature/navigation_feature.h",
-    "feature/render_widget_feature.cc",
-    "feature/render_widget_feature.h",
-    "feature/settings_feature.cc",
-    "feature/settings_feature.h",
-    "feature/tab_control_feature.cc",
-    "feature/tab_control_feature.h",
   ]
 
   deps = [
+    ":feature",
     "//blimp/common",
     "//blimp/net",
     "//cc",
     "//cc/proto",
-    "//components/url_formatter",
     "//gpu/command_buffer/client",
     "//gpu/command_buffer/client:gl_in_process_context",
     "//gpu/command_buffer/client:gles2_c_lib",
     "//gpu/command_buffer/client:gles2_implementation",
     "//gpu/command_buffer/common:gles2_utils",
     "//gpu/skia_bindings",
     "//net",
     "//skia",
     "//third_party/WebKit/public:blink_headers",
-    "//ui/base/ime:text_input_types",
     "//ui/events:gesture_detection",
     "//ui/events/blink",
     "//ui/events/gestures/blink",
     "//ui/gl",
   ]
 
   public_deps = [
     "//blimp/common/proto",
   ]
 }
 
 source_set("feature_unit_tests") {
   testonly = true
 
   sources = [
     "feature/compositor/blimp_compositor_manager_unittest.cc",
     "feature/navigation_feature_unittest.cc",
     "feature/render_widget_feature_unittest.cc",
     "feature/tab_control_feature_unittest.cc",
   ]
 
   deps = [
     ":feature",

[Kevin M, 2016/05/02 21:32:39]

Already pulled in indirectly by feature_compositor?

[haibinlu, 2016/05/03 19:32:43]

Done.

+    ":feature_compositor",
     "//base",
     "//base/test:run_all_unittests",
     "//base/test:test_support",
     "//blimp/common",
     "//blimp/common/proto",
     "//blimp/net",
     "//blimp/net:test_support",
     "//cc/proto",
     "//net",
     "//net:test_support",
@@ skipping 16 matching lines @@
       "app/linux/blimp_client_session_linux.cc",
       "app/linux/blimp_client_session_linux.h",
       "app/linux/blimp_display_manager.cc",
       "app/linux/blimp_display_manager.h",
       "app/linux/blimp_main.cc",
     ]
 
     deps = [
       ":client",
       ":feature",
+      ":feature_compositor",
       "//base",
       "//blimp/net",
       "//net",
       "//ui/events/platform/x11",
       "//ui/platform_window",
       "//ui/platform_window/x11",
     ]
 
     public_configs = [ "//build/config/linux:x11" ]
     public_deps = [
@@ skipping 151 matching lines @@
 
     java_files = [
       "app/android/javatests/src/org/chromium/blimp/auth/MockTokenSource.java",
       "app/android/javatests/src/org/chromium/blimp/auth/RetryingTokenSourceTest.java",
     ]
   }
 
   shared_library("blimp_client_android") {
     deps = [
       ":client",
       ":feature",

[Kevin M, 2016/05/02 21:32:39]

Not needed

[haibinlu, 2016/05/03 19:32:42]

Done.

+      ":feature_compositor",
       ":jni_headers",
       "//base",
       "//blimp/common",
       "//blimp/common/proto",
       "//blimp/net",
       "//components/safe_json/android:safe_json_jni_headers",
       "//components/url_formatter",
       "//net",
       "//skia",
       "//ui/base/ime:text_input_types",
@@ skipping 46 matching lines @@
     apk_name = "BlimpTest"
     apk_under_test = ":blimp_apk"
     android_manifest = blimp_test_apk_manifest
     deps = [
       ":blimp_test_apk_manifest",
       ":blimp_test_java",
       google_play_services_resources,
     ]
   }
 }