Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1929703002: PPC: [api] Expose FunctionCallbackInfo::NewTarget (Closed)

Created:
4 years, 7 months ago by JaideepBajwa
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [api] Expose FunctionCallbackInfo::NewTarget Port 306c412ce04a7c21a208e33dfce530536453c20d Original commit message: This is needed by Blink to implement the Custom Elements spec. R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4261 LOG=N Committed: https://crrev.com/4f75124044899366e1492529fe9bea4597d2aefc Cr-Commit-Position: refs/heads/master@{#35838}

Patch Set 1 #

Total comments: 2

Patch Set 2 : removed extra stack space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M src/ppc/builtins-ppc.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 4 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 7 months ago (2016-04-27 21:18:00 UTC) #1
MTBrandyberry
https://codereview.chromium.org/1929703002/diff/1/src/ppc/code-stubs-ppc.cc File src/ppc/code-stubs-ppc.cc (right): https://codereview.chromium.org/1929703002/diff/1/src/ppc/code-stubs-ppc.cc#newcode5678 src/ppc/code-stubs-ppc.cc:5678: // Create 5 extra slots on stack: FunctionCallbackInfo shrunk, ...
4 years, 7 months ago (2016-04-27 21:39:58 UTC) #2
MTBrandyberry
lgtm
4 years, 7 months ago (2016-04-27 22:07:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929703002/20001
4 years, 7 months ago (2016-04-27 22:16:52 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 22:38:20 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:01:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f75124044899366e1492529fe9bea4597d2aefc
Cr-Commit-Position: refs/heads/master@{#35838}

Powered by Google App Engine
This is Rietveld 408576698