editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart - Issue 19297002: Try to fix Windows bots. Use absolute path instead of canonical.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart

Issue 19297002: Try to fix Windows bots. Use absolute path instead of canonical. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart

diff --git a/editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart b/editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart

index d73f79e4115878af0a3209b2c478d07869a9ab37..d6e79e8f64e989c7c5fa7860ea60491fff46fcd1 100644

--- a/editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart

+++ b/editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart

@@ -88,7 +88,9 @@ class JavaFile {

return new JavaFile(parent);

}

String getAbsolutePath() => pathos.absolute(_path);

- String getCanonicalPath() => _newFile().fullPathSync();

+ // TODO(scheglov) it seems that this method is broken on Windows

+// String getCanonicalPath() => _newFile().fullPathSync();

+ String getCanonicalPath() => getAbsolutePath();

JavaFile getAbsoluteFile() => new JavaFile(getAbsolutePath());

JavaFile getCanonicalFile() => new JavaFile(getCanonicalPath());

bool exists() {

« no previous file with comments | « no previous file | pkg/analyzer_experimental/lib/src/generated/java_io.dart » ('j') | no next file with comments »