Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/common/safe_browsing/file_type_policies.cc

Issue 1929693003: Populate download_file_types proto and filter it for each platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@file_type_polices2
Patch Set: fix chromeos detection again Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/safe_browsing/file_type_policies.cc
diff --git a/chrome/common/safe_browsing/file_type_policies.cc b/chrome/common/safe_browsing/file_type_policies.cc
index 284011abf2ad36589fd8320a740d9757045c8fbe..09fa1fb15702a0cdacfddf3078c0c4c8da349ee3 100644
--- a/chrome/common/safe_browsing/file_type_policies.cc
+++ b/chrome/common/safe_browsing/file_type_policies.cc
@@ -16,11 +16,11 @@ namespace safe_browsing {
FileTypePolicies::FileTypePolicies() {
// Setup a file-type policy to use if the ResourceBundle is unreadable.
// This should normally never be used.
- last_resort_default_.set_uma_value(99999); // TODO: Add this to xml.
+ last_resort_default_.set_uma_value(-1l);
+ last_resort_default_.set_ping_setting(DownloadFileType::NO_PING);
auto settings = last_resort_default_.add_platform_settings();
settings->set_danger_level(DownloadFileType::ALLOW_ON_USER_GESTURE);
settings->set_auto_open_hint(DownloadFileType::DISALLOW_AUTO_OPEN);
- settings->set_ping_setting(DownloadFileType::NO_PING);
}
FileTypePolicies::~FileTypePolicies() {}

Powered by Google App Engine
This is Rietveld 408576698