Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1929673002: S390: Get rid of AllocationFlags::TAG_OBJECT (Closed)

Created:
4 years, 7 months ago by bcleung
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Get rid of AllocationFlags::TAG_OBJECT Port 9bf7a31a8ced123b8bd051f3ef39625104a1124f Original commit message: Default (and only way) is now to retrieve a tagged object. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/2950df96b9b341b00c5a4daaa183ead303b6394a Cr-Commit-Position: refs/heads/master@{#35874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -45 lines) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 8 chunks +10 lines, -15 lines 0 comments Download
M src/s390/codegen-s390.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/s390/macro-assembler-s390.cc View 11 chunks +15 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JoranSiu
lgtm. On a slightly related note, we should consider using LA instead of AddP to ...
4 years, 7 months ago (2016-04-27 22:28:57 UTC) #1
john.yan
lgtm lgtm
4 years, 7 months ago (2016-04-28 14:50:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929673002/1
4 years, 7 months ago (2016-04-28 15:24:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 15:59:36 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2950df96b9b341b00c5a4daaa183ead303b6394a
Cr-Commit-Position: refs/heads/master@{#35874}

Powered by Google App Engine
This is Rietveld 408576698