[DevTools] If no device frame art is available, ensure neutral inset values are defined when applyi…

[DevTools] If no device frame art is available, ensure neutral inset values are defined when applying metrics.

BUG=605724
Committed: https://crrev.com/8da946c11d2f47b862fbf0b3c146ea2517966bc2
Cr-Commit-Position: refs/heads/master@{#390374}

[mmccoy1, 2016-04-27 18:17:06]

mmccoy@google.com changed reviewers:
+ dgozman@chromium.org, mmccoy@google.com, paulirish@chromium.org

[mmccoy1, 2016-04-27 18:17:07]

Fix exception when outline insets were undefined.

[dgozman, 2016-04-27 18:48:16]

https://codereview.chromium.org/1929603002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js
(right):

https://codereview.chromium.org/1929603002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js:437:
var outline = (this._deviceOutlineSetting.get() &&
Runtime.experiments.isEnabled("deviceFrames")) ? orientation.outlineInsets : new
Insets(0,0,0,0);
Let's fix here instead:

var outline = new Insets(0, 0, 0, 0);
if (Runtime.experiments.isEnabled("deviceFrames") &&
this._deviceOutlineSetting.get())
    outline = orientation.outlineInsets || outline;

https://codereview.chromium.org/1929603002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js:504: *
@param {!Insets|null} outline
... and mark this as non-null.

[mmccoy1, 2016-04-27 20:23:52]

https://codereview.chromium.org/1929603002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js
(right):

https://codereview.chromium.org/1929603002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js:437:
var outline = (this._deviceOutlineSetting.get() &&
Runtime.experiments.isEnabled("deviceFrames")) ? orientation.outlineInsets : new
Insets(0,0,0,0);
On 2016/04/27 at 18:48:16, dgozman wrote:
> Let's fix here instead:
> 
> var outline = new Insets(0, 0, 0, 0);
> if (Runtime.experiments.isEnabled("deviceFrames") &&
this._deviceOutlineSetting.get())
>     outline = orientation.outlineInsets || outline;

Right, thanks!

https://codereview.chromium.org/1929603002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js:504: *
@param {!Insets|null} outline
On 2016/04/27 at 18:48:16, dgozman wrote:
> ... and mark this as non-null.

Done.

[dgozman, 2016-04-27 20:40:50]

lgtm

[mmccoy, 2016-04-28 13:40:26]

The CQ bit was checked by mmccoy@chromium.org

[commit-bot: I haz the power, 2016-04-28 13:40:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929603002/20001

[commit-bot: I haz the power, 2016-04-28 14:46:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:18:18]

Patchset 2 (id:??) landed as
https://crrev.com/8da946c11d2f47b862fbf0b3c146ea2517966bc2
Cr-Commit-Position: refs/heads/master@{#390374}

[commit-bot: I haz the power, 2016-04-30 17:55:40]

Description was changed from

==========
[DevTools] If no device frame art is available, ensure neutral inset values are
defined when applying metrics.

BUG=605724
==========

to

==========
[DevTools] If no device frame art is available, ensure neutral inset values are
defined when applying metrics.

BUG=605724

Committed: https://crrev.com/8da946c11d2f47b862fbf0b3c146ea2517966bc2
Cr-Commit-Position: refs/heads/master@{#390374}
==========