[Polymer10] Convert alerts-table.html to Polymer 1.0

[Polymer10] Convert alerts-table.html to Polymer 1.0

BUG=catapult:#2285
R=dtu@chromium.org
NOTRY=true
NOPRESUBMIT=true

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/45ee45611d7053b19f82f0e86cb22c379313283f

[eakuefner, 2016-04-27 15:51:34]

Please, take a look.

[dtu, 2016-04-27 17:34:25]

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
File dashboard/dashboard/elements/alerts-table.html (right):

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/alerts-table.html:367: Polymer('alerts-table', {
Don't need 'alerts-table' here.

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/alerts-table.html:400: currentCheckboxId: { value:
null},
nit: space.

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
File dashboard/dashboard/elements/base-chart.html (right):

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/base-chart.html:8: <dom-module id="base-chart"
attributes="chartTitle units flotData">
Change these to properties.

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/base-chart.html:99: </polymer-element>
This one too.

[dtu, 2016-04-27 17:43:55]

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
File dashboard/dashboard/elements/alerts-table.html (right):

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/alerts-table.html:329: <bisect-status
hidden$="{{!computeTruthy(bug_id)}}"
! autocasts to bool, don't need computeTruthy

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/alerts-table.html:415: computeExistsOrExpanded:
(prop, exanded) => !prop || expanded,
computeAbsentOrExpanded

[eakuefner, 2016-04-28 15:54:54]

Please, take another look.

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
File dashboard/dashboard/elements/alerts-table.html (right):

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/alerts-table.html:329: <bisect-status
hidden$="{{!computeTruthy(bug_id)}}"
On 2016/04/27 at 17:43:54, dtu wrote:
> ! autocasts to bool, don't need computeTruthy

Done.

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/alerts-table.html:367: Polymer('alerts-table', {
On 2016/04/27 at 17:34:25, dtu wrote:
> Don't need 'alerts-table' here.

Done.

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/alerts-table.html:400: currentCheckboxId: { value:
null},
On 2016/04/27 at 17:34:24, dtu wrote:
> nit: space.

Done.

https://codereview.chromium.org/1929563002/diff/40001/dashboard/dashboard/ele...
dashboard/dashboard/elements/alerts-table.html:415: computeExistsOrExpanded:
(prop, exanded) => !prop || expanded,
On 2016/04/27 at 17:43:54, dtu wrote:
> computeAbsentOrExpanded

Done.

[eakuefner-google (do not use), 2016-04-28 16:48:52]

eakuefner@google.com changed reviewers:
+ eakuefner@google.com, sullivan@chromium.org

[eakuefner-google (do not use), 2016-04-28 16:48:53]

PTAL.

[sullivan, 2016-04-28 17:06:22]

lgtm

[eakuefner, 2016-04-28 21:51:39]

Description was changed from

==========
[Polymer10] Convert alerts-table.html to Polymer 1.0

BUG=catapult:#2285
R=dtu@chromium.org
==========

to

==========
[Polymer10] Convert alerts-table.html to Polymer 1.0

BUG=catapult:#2285
R=dtu@chromium.org
NOTRY=true
NOPRESUBMIT=true
==========

[eakuefner, 2016-04-28 21:51:40]

The CQ bit was checked by eakuefner@chromium.org

[commit-bot: I haz the power, 2016-04-28 21:51:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929563002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929563002/80001

[commit-bot: I haz the power, 2016-04-28 21:51:57]

Description was changed from

==========
[Polymer10] Convert alerts-table.html to Polymer 1.0

BUG=catapult:#2285
R=dtu@chromium.org
NOTRY=true
NOPRESUBMIT=true
==========

to

==========
[Polymer10] Convert alerts-table.html to Polymer 1.0

BUG=catapult:#2285
R=dtu@chromium.org
NOTRY=true
NOPRESUBMIT=true

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-04-28 21:51:58]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...