Revert of Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks

Revert of Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks (patchset #4 id:100001 of https://codereview.chromium.org/1904273002/ )

Reason for revert:
This seems to have broken some android unit tests:

I  181.858s run_tests_on_device(01ab756b0330210f)  [ RUN      ] SupervisedUserServiceTest.ChangesIncludedSessionOnChangedSettings
I  181.858s run_tests_on_device(01ab756b0330210f)  [INFO:profile_sync_service.cc(2370)] ConfigureDataTypeManager not invoked because backend is not initialized
I  181.858s run_tests_on_device(01ab756b0330210f)  [FATAL:thread_restrictions.cc(57)] LazyInstance/Singleton is not allowed to be used on this thread.  Most likely it's because this thread is not joinable, so AtExitManager may have deleted the object on shutdown, leading to a potential shutdown crash.

Original issue's description:
> Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks
>
> CONTINUE_ON_SHUTDOWN means the thread running the task will not be
> joined on shutdown and may not have a valid singleton/lazy_instance
> at that moment.
>
> Also made DhcpcsvcInitSingleton explicitly leaky to avoid
> the AssertSingletonAllowed() dcheck.
>
> BUG=478209
TBR=mef@chromium.org,danakj@chromium.org,gab@chromium.org,robliao@chromium.org,manzagop@chromium.org,rsleevi@chromium.org,pmonette@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478209
Committed: https://crrev.com/70c6564dbec07c540c6e7125f9c956790279255c
Cr-Commit-Position: refs/heads/master@{#390205}

[robertshield, 2016-04-27 21:52:55]

Created Revert of Enforce singleton not allowed behavior for
CONTINUE_ON_SHUTDOWN tasks

[commit-bot: I haz the power, 2016-04-27 21:53:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929543003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929543003/1

[commit-bot: I haz the power, 2016-04-27 21:53:52]

Description was changed from

==========
Revert of Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks
(patchset #4 id:100001 of https://codereview.chromium.org/1904273002/ )

Reason for revert:
This seems to have broken some android unit tests:

I  181.858s run_tests_on_device(01ab756b0330210f)  [ RUN      ]
SupervisedUserServiceTest.ChangesIncludedSessionOnChangedSettings
I  181.858s run_tests_on_device(01ab756b0330210f) 
[INFO:profile_sync_service.cc(2370)] ConfigureDataTypeManager not invoked
because backend is not initialized
I  181.858s run_tests_on_device(01ab756b0330210f) 
[FATAL:thread_restrictions.cc(57)] LazyInstance/Singleton is not allowed to be
used on this thread.  Most likely it's because this thread is not joinable, so
AtExitManager may have deleted the object on shutdown, leading to a potential
shutdown crash.


Original issue's description:
> Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks
> 
> CONTINUE_ON_SHUTDOWN means the thread running the task will not be
> joined on shutdown and may not have a valid singleton/lazy_instance
> at that moment.
> 
> Also made DhcpcsvcInitSingleton explicitly leaky to avoid 
> the AssertSingletonAllowed() dcheck.
> 
> BUG=478209

TBR=mef@chromium.org,danakj@chromium.org,gab@chromium.org,robliao@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478209
==========

to

==========
Revert of Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks
(patchset #4 id:100001 of https://codereview.chromium.org/1904273002/ )

Reason for revert:
This seems to have broken some android unit tests:

I  181.858s run_tests_on_device(01ab756b0330210f)  [ RUN      ]
SupervisedUserServiceTest.ChangesIncludedSessionOnChangedSettings
I  181.858s run_tests_on_device(01ab756b0330210f) 
[INFO:profile_sync_service.cc(2370)] ConfigureDataTypeManager not invoked
because backend is not initialized
I  181.858s run_tests_on_device(01ab756b0330210f) 
[FATAL:thread_restrictions.cc(57)] LazyInstance/Singleton is not allowed to be
used on this thread.  Most likely it's because this thread is not joinable, so
AtExitManager may have deleted the object on shutdown, leading to a potential
shutdown crash.


Original issue's description:
> Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks
> 
> CONTINUE_ON_SHUTDOWN means the thread running the task will not be
> joined on shutdown and may not have a valid singleton/lazy_instance
> at that moment.
> 
> Also made DhcpcsvcInitSingleton explicitly leaky to avoid 
> the AssertSingletonAllowed() dcheck.
> 
> BUG=478209

TBR=mef@chromium.org,danakj@chromium.org,gab@chromium.org,robliao@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478209
==========

[commit-bot: I haz the power, 2016-04-27 21:53:53]

Committed patchset #1 (id:1)

[chromium-reviews, 2016-04-28 12:35:36]

lgtm, weird that CQ didn't catch this, racy? Probably found another true
but with this new check :-)

Le mer. 27 avr. 2016 17:53, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> a
écrit :

> Committed patchset #1 (id:1)
>
> https://codereview.chromium.org/1929543003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-04-30 17:13:39]

Patchset 1 (id:??) landed as
https://crrev.com/70c6564dbec07c540c6e7125f9c956790279255c
Cr-Commit-Position: refs/heads/master@{#390205}

[commit-bot: I haz the power, 2016-04-30 17:52:16]

Description was changed from

==========
Revert of Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks
(patchset #4 id:100001 of https://codereview.chromium.org/1904273002/ )

Reason for revert:
This seems to have broken some android unit tests:

I  181.858s run_tests_on_device(01ab756b0330210f)  [ RUN      ]
SupervisedUserServiceTest.ChangesIncludedSessionOnChangedSettings
I  181.858s run_tests_on_device(01ab756b0330210f) 
[INFO:profile_sync_service.cc(2370)] ConfigureDataTypeManager not invoked
because backend is not initialized
I  181.858s run_tests_on_device(01ab756b0330210f) 
[FATAL:thread_restrictions.cc(57)] LazyInstance/Singleton is not allowed to be
used on this thread.  Most likely it's because this thread is not joinable, so
AtExitManager may have deleted the object on shutdown, leading to a potential
shutdown crash.


Original issue's description:
> Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks
> 
> CONTINUE_ON_SHUTDOWN means the thread running the task will not be
> joined on shutdown and may not have a valid singleton/lazy_instance
> at that moment.
> 
> Also made DhcpcsvcInitSingleton explicitly leaky to avoid 
> the AssertSingletonAllowed() dcheck.
> 
> BUG=478209

TBR=mef@chromium.org,danakj@chromium.org,gab@chromium.org,robliao@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478209
==========

to

==========
Revert of Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks
(patchset #4 id:100001 of https://codereview.chromium.org/1904273002/ )

Reason for revert:
This seems to have broken some android unit tests:

I  181.858s run_tests_on_device(01ab756b0330210f)  [ RUN      ]
SupervisedUserServiceTest.ChangesIncludedSessionOnChangedSettings
I  181.858s run_tests_on_device(01ab756b0330210f) 
[INFO:profile_sync_service.cc(2370)] ConfigureDataTypeManager not invoked
because backend is not initialized
I  181.858s run_tests_on_device(01ab756b0330210f) 
[FATAL:thread_restrictions.cc(57)] LazyInstance/Singleton is not allowed to be
used on this thread.  Most likely it's because this thread is not joinable, so
AtExitManager may have deleted the object on shutdown, leading to a potential
shutdown crash.

Original issue's description:
> Enforce singleton not allowed behavior for CONTINUE_ON_SHUTDOWN tasks
>
> CONTINUE_ON_SHUTDOWN means the thread running the task will not be
> joined on shutdown and may not have a valid singleton/lazy_instance
> at that moment.
>
> Also made DhcpcsvcInitSingleton explicitly leaky to avoid
> the AssertSingletonAllowed() dcheck.
>
> BUG=478209

TBR=mef@chromium.org,danakj@chromium.org,gab@chromium.org,robliao@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=478209

Committed: https://crrev.com/70c6564dbec07c540c6e7125f9c956790279255c
Cr-Commit-Position: refs/heads/master@{#390205}
==========