Issue 192953003: win: Don't pass a qualified name to DISALLOW_COPY_AND_ASSIGN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 192953003: win: Don't pass a qualified name to DISALLOW_COPY_AND_ASSIGN. (Closed)

Created:
6 years, 9 months ago by Nico

Modified:
6 years, 9 months ago

Reviewers:
hans

CC:
chromium-reviews, feature-media-reviews_chromium.org, yukawa, grt (UTC plus 2), xhwang

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

win: Don't pass a qualified inner class name to DISALLOW_COPY_AND_ASSIGN. DISALLOW_COPY_AND_ASSIGN expands to copy constructor and assignment operator, which are spelled using an unqualified name. No functionality change, but makes clang happier. BUG=82385 R=hans@chromium.org TBR=grt@chromium.org, xhwang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255991

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	media/midi/midi_manager_win.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	win8/test/open_with_dialog_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Nico

6 years, 9 months ago (2014-03-10 18:34:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r255991 (presubmit successful).