Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 1929503002: Reland of "[heap] Uncommit pooled pages concurrently" (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "[heap] Uncommit pooled pages concurrently" - Move the concurrent unmapping to MemoryAllocator - Hide (private) members where possible - MemoryAllocator:Free is now the bottleneck for freeing - Pooled pages are either allocated from a set of pooled pages are obtained through work stealing from the concurrent unmapper BUG=chromium:605866, chromium:581412 LOG=N This reverts commit 25ff296c4c8d35c63255531a86f877f20eeaeb62. Committed: https://crrev.com/45f52fcb60f75bfe5dc5f6a83317a14db631cf18 Cr-Commit-Position: refs/heads/master@{#35910}

Patch Set 1 : baseline #

Patch Set 2 : Fixed pooling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -149 lines) Patch
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 3 chunks +0 lines, -12 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +0 lines, -74 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap/spaces.h View 1 6 chunks +96 lines, -18 lines 0 comments Download
M src/heap/spaces.cc View 14 chunks +109 lines, -40 lines 0 comments Download
M test/cctest/heap/test-spaces.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Michael Lippautz
ptal -- will only land after Canary on 04/28.
4 years, 7 months ago (2016-04-27 13:49:45 UTC) #3
Hannes Payer (out of office)
On 2016/04/27 13:49:45, Michael Lippautz wrote: > ptal -- will only land after Canary on ...
4 years, 7 months ago (2016-04-29 13:55:00 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929503002/20001
4 years, 7 months ago (2016-04-29 13:56:22 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 14:21:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929503002/20001
4 years, 7 months ago (2016-04-29 14:25:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 14:27:46 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:58 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/45f52fcb60f75bfe5dc5f6a83317a14db631cf18
Cr-Commit-Position: refs/heads/master@{#35910}

Powered by Google App Engine
This is Rietveld 408576698