Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: git_cl.py

Issue 1929483004: Revert of git cl try: don't skip presubmit builders, but set dry_run property. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 172337e565d4399c2d1b61e4a9d975d221c90d78..7d3c1055c23e0fa986b34cfca09003c41a939b19 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -337,8 +337,6 @@
'rietveld': rietveld_url,
},
}
- if 'presubmit' not in builder.lower():
- parameters['properties']['dry_run'] = 'true'
if tests:
parameters['properties']['testfilter'] = tests
if properties:
@@ -4318,7 +4316,8 @@
for master, builders in cq_masters.iteritems():
for builder in builders:
# Skip presubmit builders, because these will fail without LGTM.
- masters.setdefault(master, {})[builder] = ['defaulttests']
+ if 'presubmit' not in builder.lower():
+ masters.setdefault(master, {})[builder] = ['defaulttests']
if masters:
return masters
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698