Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1929483004: Revert of git cl try: don't skip presubmit builders, but set dry_run property. (Closed)

Created:
4 years, 7 months ago by tandrii(chromium)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #1 id:1 of https://codereview.chromium.org/1926663002/ ) Reason for revert: Schedules fine, but property not set: https://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14295/ reverting first, then investigating. Original issue's description: > git cl try: don't skip presubmit builders, but set dry_run property. > > R=machenbach@chromium.org,sergiyb@chromium.org > BUG=601128, 594127, 591030 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300265 TBR=machenbach@chromium.org,sergiyb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601128, 594127, 591030 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M git_cl.py View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tandrii(chromium)
Created Revert of git cl try: don't skip presubmit builders, but set dry_run property.
4 years, 7 months ago (2016-04-28 12:28:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929483004/1
4 years, 7 months ago (2016-04-28 12:29:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300274
4 years, 7 months ago (2016-04-28 12:29:12 UTC) #4
Michael Achenbach
4 years, 7 months ago (2016-04-28 12:34:09 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698