Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1929483002: [css-grid] Fix static position for positioned grid items (Closed)

Created:
4 years, 7 months ago by Manuel Rego
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Fix static position for positioned grid items The spec was updated to define properly the static position for positioned grid items, but we didn't update the implementation yet: https://drafts.csswg.org/css-grid-1/issues-wd-20150108#issue-1 We were only setting the static position when the start line was not auto. Otherwise we were using the default one which includes the padding. With the spec change we need to set it always, even if the start line is auto. Updated several tests to follow the new expected behavior. BUG=607137 Committed: https://crrev.com/92d518467d7a6ff962ae2c3c8c44c903e9472ef0 Cr-Commit-Position: refs/heads/master@{#390215}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
Manuel Rego
4 years, 7 months ago (2016-04-27 12:00:57 UTC) #2
cbiesinger
lgtm
4 years, 7 months ago (2016-04-27 16:28:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929483002/1
4 years, 7 months ago (2016-04-27 19:23:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 22:24:29 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:13:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92d518467d7a6ff962ae2c3c8c44c903e9472ef0
Cr-Commit-Position: refs/heads/master@{#390215}

Powered by Google App Engine
This is Rietveld 408576698