Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1929473002: [build] Move gyp folder (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Move gyp folder Uses now the same location chromium uses and which some tools expect. BUG=chromium:474921 LOG=n Committed: https://crrev.com/7f3954c57b90999eb4840be34ebc194169ffd1b1 Cr-Commit-Position: refs/heads/master@{#35817}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M .gitignore View 1 2 chunks +1 line, -1 line 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M Makefile View 2 chunks +4 lines, -4 lines 0 comments Download
M Makefile.android View 1 chunk +1 line, -1 line 0 comments Download
M Makefile.nacl View 1 chunk +1 line, -1 line 0 comments Download
M build/gyp_v8 View 1 chunk +1 line, -1 line 0 comments Download
M build/vs_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/mingw-generate-makefiles.sh View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929473002/20001
4 years, 7 months ago (2016-04-27 10:12:37 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 10:33:40 UTC) #5
Michael Achenbach
PTAL
4 years, 7 months ago (2016-04-27 11:30:14 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-04-27 11:46:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929473002/20001
4 years, 7 months ago (2016-04-27 12:33:43 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 12:35:43 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 12:37:46 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f3954c57b90999eb4840be34ebc194169ffd1b1
Cr-Commit-Position: refs/heads/master@{#35817}

Powered by Google App Engine
This is Rietveld 408576698