impl/memory/datastore_test.go - Issue 1929423002: filter/txnBuf: Use fully-qualified App ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/memory/datastore_test.go

Issue 1929423002: filter/txnBuf: Use fully-qualified App ID. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master

Patch Set: Use public methods for defining Info service in tests. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: impl/memory/datastore_test.go

diff --git a/impl/memory/datastore_test.go b/impl/memory/datastore_test.go

index 54ded94a0599fd44739ed928f138e8ae90493a7f..3b9f91e212dfc2f75d09512216539fc0785e295e 100644

--- a/impl/memory/datastore_test.go

+++ b/impl/memory/datastore_test.go

@@ -685,11 +685,12 @@ func TestNewDatastore(t *testing.T) {

t.Parallel()

Convey("Can get and use a NewDatastore", t, func() {

- ds, err := NewDatastore("aid", "ns")

- So(err, ShouldBeNil)

+ c := UseWithAppID(context.Background(), "dev~aid")

+ c = infoS.Get(c).MustNamespace("ns")

+ ds := NewDatastore(infoS.Get(c))

k := ds.MakeKey("Something", 1)

- So(k.AppID(), ShouldEqual, "aid")

+ So(k.AppID(), ShouldEqual, "dev~aid")

So(k.Namespace(), ShouldEqual, "ns")

type Model struct {

« no previous file with comments | « impl/memory/datastore.go ('k') | impl/memory/info.go » ('j') | no next file with comments »