Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: impl/memory/info_test.go

Issue 1929423002: filter/txnBuf: Use fully-qualified App ID. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: Go back to "dev~", too many things care. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« impl/memory/datastore_test.go ('K') | « impl/memory/info.go ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package memory 5 package memory
6 6
7 import ( 7 import (
8 "testing" 8 "testing"
9 9
10 "github.com/luci/gae/service/info" 10 "github.com/luci/gae/service/info"
(...skipping 11 matching lines...) Expand all
22 i.MustNamespace("valid_namespace_name") 22 i.MustNamespace("valid_namespace_name")
23 }, ShouldNotPanic) 23 }, ShouldNotPanic)
24 So(func() { 24 So(func() {
25 i.MustNamespace("invalid namespace name") 25 i.MustNamespace("invalid namespace name")
26 }, ShouldPanic) 26 }, ShouldPanic)
27 }) 27 })
28 28
29 Convey("Testable interface works", t, func() { 29 Convey("Testable interface works", t, func() {
30 c := Use(context.Background()) 30 c := Use(context.Background())
31 c = useGID(c, func(mod *globalInfoData) { 31 c = useGID(c, func(mod *globalInfoData) {
32 » » » mod.appid = "app-id" 32 » » » mod.appID = "app-id"
33 » » » mod.fqAppID = "dev~app-id"
33 }) 34 })
34 35
35 // Default value. 36 // Default value.
36 So(info.Get(c).AppID(), ShouldEqual, "app-id") 37 So(info.Get(c).AppID(), ShouldEqual, "app-id")
38 So(info.Get(c).FullyQualifiedAppID(), ShouldEqual, "dev~app-id")
37 So(info.Get(c).RequestID(), ShouldEqual, "test-request-id") 39 So(info.Get(c).RequestID(), ShouldEqual, "test-request-id")
38 40
39 // Setting to "override" applies to initial context. 41 // Setting to "override" applies to initial context.
40 c = info.Get(c).Testable().SetRequestID("override") 42 c = info.Get(c).Testable().SetRequestID("override")
41 So(info.Get(c).RequestID(), ShouldEqual, "override") 43 So(info.Get(c).RequestID(), ShouldEqual, "override")
42 44
43 // Derive inner context, "override" applies. 45 // Derive inner context, "override" applies.
44 c = info.Get(c).MustNamespace("valid_namespace_name") 46 c = info.Get(c).MustNamespace("valid_namespace_name")
45 So(info.Get(c).RequestID(), ShouldEqual, "override") 47 So(info.Get(c).RequestID(), ShouldEqual, "override")
46 }) 48 })
47 } 49 }
OLDNEW
« impl/memory/datastore_test.go ('K') | « impl/memory/info.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698