Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 1929403002: GN: fix bootstrap (Closed)

Created:
4 years, 7 months ago by NGG
Modified:
4 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: fix bootstrap //base/trace_event/memory_dump_manager.cc now needs the generated //base/debug/debugging_flags.h file. Generating that file when building manually with ninja fixes bootstrapping. R=brettw@chromium.org BUG= Committed: https://crrev.com/c86fe9393074586d43d9b83ee2866cfa201ad7d4 Cr-Commit-Position: refs/heads/master@{#391055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M tools/gn/bootstrap/bootstrap.py View 1 chunk +17 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
NGG
4 years, 7 months ago (2016-04-29 17:25:19 UTC) #1
brettw
lgtm
4 years, 7 months ago (2016-05-02 17:11:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929403002/1
4 years, 7 months ago (2016-05-02 20:34:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 21:24:24 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 21:25:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c86fe9393074586d43d9b83ee2866cfa201ad7d4
Cr-Commit-Position: refs/heads/master@{#391055}

Powered by Google App Engine
This is Rietveld 408576698