Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 1929353002: CORS-RFC1918: Service Workers (Closed)

Created:
4 years, 7 months ago by Mike West
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CORS-RFC1918: Teach Service Workers about address spaces. Service Workers don't currently understand address spaces, this patch does the minimum amount of work necessary to ensure two things: 1. The initial request for a service worker has the correct address space associated with the loader (the changes the `WebEmbeddedWorker*`). 2. The address space of the response is piped down through the content layer (the change to `resource_loader.cc`: this worked for everything up through now, but Service Workers have a caching mechanism inbetween URLRequest and here which made `GetSocketAddress` unreliable. The cached response info, however, is accurate). BUG=591672 R=jochen@chromium.org Committed: https://crrev.com/64ecde25bae52de55a682386ad05701498ecd5bd Cr-Commit-Position: refs/heads/master@{#391170}

Patch Set 1 #

Patch Set 2 : Works. #

Messages

Total messages: 9 (4 generated)
Mike West
WDYT, Jochen?
4 years, 7 months ago (2016-05-02 08:58:04 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-02 16:09:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929353002/20001
4 years, 7 months ago (2016-05-03 04:45:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 04:53:08 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 04:54:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64ecde25bae52de55a682386ad05701498ecd5bd
Cr-Commit-Position: refs/heads/master@{#391170}

Powered by Google App Engine
This is Rietveld 408576698