Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1929343002: Remove skstd::is_function. (Closed)

Created:
4 years, 7 months ago by bungeman-skia
Modified:
4 years, 7 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove skstd::is_function. The VC++ STL with 2015u2 now provides a complete std::is_function. Also, Skia is no longer using skstd::is_function. Committed: https://skia.googlesource.com/skia/+/b4d46f03db6080da4ad3b228d37e0760c1029015

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M include/private/SkTLogic.h View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929343002/1
4 years, 7 months ago (2016-04-29 14:42:55 UTC) #4
bungeman-skia
4 years, 7 months ago (2016-04-29 14:43:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 15:09:52 UTC) #8
mtklein
lgtm
4 years, 7 months ago (2016-04-29 15:26:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929343002/1
4 years, 7 months ago (2016-04-29 15:26:20 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 15:27:17 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b4d46f03db6080da4ad3b228d37e0760c1029015

Powered by Google App Engine
This is Rietveld 408576698