Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1929333002: Change installer log for Chromium to chromium_installer.log (Closed)

Created:
4 years, 7 months ago by zmin
Modified:
4 years, 7 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change installer log for Chromium to chromium_installer.log BUG=597654 Committed: https://crrev.com/9d29a7198ebde81e5fc554d13354a6ca2ae40637 Cr-Commit-Position: refs/heads/master@{#390668}

Patch Set 1 #

Total comments: 1

Patch Set 2 : cr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/installer/util/logging_installer.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
zmin
4 years, 7 months ago (2016-04-29 14:00:36 UTC) #2
grt (UTC plus 2)
lgtm w/ a nit. thanks! https://codereview.chromium.org/1929333002/diff/1/chrome/installer/util/logging_installer.cc File chrome/installer/util/logging_installer.cc (right): https://codereview.chromium.org/1929333002/diff/1/chrome/installer/util/logging_installer.cc#newcode120 chrome/installer/util/logging_installer.cc:120: #else // CHROMIUM_BUILD nit: ...
4 years, 7 months ago (2016-04-29 15:19:46 UTC) #3
zmin
On 2016/04/29 15:19:46, grt wrote: > lgtm w/ a nit. thanks! > > https://codereview.chromium.org/1929333002/diff/1/chrome/installer/util/logging_installer.cc > ...
4 years, 7 months ago (2016-04-29 15:45:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929333002/20001
4 years, 7 months ago (2016-04-29 15:46:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 16:33:26 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:26:20 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9d29a7198ebde81e5fc554d13354a6ca2ae40637
Cr-Commit-Position: refs/heads/master@{#390668}

Powered by Google App Engine
This is Rietveld 408576698