Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.txt

Issue 192933002: Check that classes with non-trivial destructors have finalization support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.txt
diff --git a/tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.txt b/tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.txt
index a7cf651e4a21ae736279fe908094208bfd7c85ad..fd4978512d36a4b617e14283fbfcd8e2c05b9edf 100644
--- a/tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.txt
+++ b/tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.txt
@@ -6,7 +6,7 @@ class PartObject {
RefPtr<HeapObject> m_obj;
^
./ref_ptr_to_gc_managed_class.h:20:1: warning: [blink-gc] Class 'HeapObject' contains invalid fields.
-class HeapObject : public GarbageCollected<HeapObject> {
+class HeapObject : public GarbageCollectedFinalized<HeapObject> {
^
./ref_ptr_to_gc_managed_class.h:25:5: note: [blink-gc] RefPtr field 'm_objs' to a GC managed class declared here:
Vector<RefPtr<HeapObject> > m_objs;
« no previous file with comments | « tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698