tools/clang/blink_gc_plugin/tests/own_ptr_to_gc_managed_class.txt - Issue 192933002: Check that classes with non-trivial destructors have finalization support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/own_ptr_to_gc_managed_class.txt

Issue 192933002: Check that classes with non-trivial destructors have finalization support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/own_ptr_to_gc_managed_class.h ('k') | tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/own_ptr_to_gc_managed_class.txt

diff --git a/tools/clang/blink_gc_plugin/tests/own_ptr_to_gc_managed_class.txt b/tools/clang/blink_gc_plugin/tests/own_ptr_to_gc_managed_class.txt

index dc1b2b2f7a051b947e9d30db3539285578d80483..b1dac2c6f1482bebf964a63c16702fe26f12df8c 100644

--- a/tools/clang/blink_gc_plugin/tests/own_ptr_to_gc_managed_class.txt

+++ b/tools/clang/blink_gc_plugin/tests/own_ptr_to_gc_managed_class.txt

@@ -6,7 +6,7 @@ class PartObject {

OwnPtr<HeapObject> m_obj;

./own_ptr_to_gc_managed_class.h:20:1: warning: [blink-gc] Class 'HeapObject' contains invalid fields.

-class HeapObject : public GarbageCollected<HeapObject> {

+class HeapObject : public GarbageCollectedFinalized<HeapObject> {

./own_ptr_to_gc_managed_class.h:24:5: note: [blink-gc] OwnPtr field 'm_objs' to a GC managed class declared here:

Vector<OwnPtr<HeapObject> > m_objs;