tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt - Issue 192933002: Check that classes with non-trivial destructors have finalization support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt

Issue 192933002: Check that classes with non-trivial destructors have finalization support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: mixin support Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h ('K') | « tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.cpp ('k') | tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt

diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt

new file mode 100644

index 0000000000000000000000000000000000000000..b768371511ef7798c52e0b8fb6584af19cf13646

--- /dev/null

+++ b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.txt

@@ -0,0 +1,8 @@

+In file included from class_requires_finalization_mixin.cpp:5:

+./class_requires_finalization_mixin.h:23:1: warning: [blink-gc] Non-finalized class 'NeedsFinalizer' requires finalization.

+class NeedsFinalizer : public GarbageCollected<NeedsFinalizer>, public Mixin {

+./class_requires_finalization_mixin.h:23:65: note: [blink-gc] Base class 'Mixin' requiring finalization declared here:

+class NeedsFinalizer : public GarbageCollected<NeedsFinalizer>, public Mixin {

+ ^

+1 warning generated.