Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp

Issue 192933002: Check that classes with non-trivial destructors have finalization support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: mixin support Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp
diff --git a/tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.cpp b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp
similarity index 50%
copy from tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.cpp
copy to tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp
index 4e0b3f3b16c37aea6cf80ccef060c6ec09097afd..85e05b7aae765b466f6cd146dd1c76e874711a21 100644
--- a/tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.cpp
+++ b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp
@@ -2,19 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "destructor_in_nonfinalized_class.h"
+#include "class_requires_finalization_base.h"
namespace WebCore {
-HeapObject::~HeapObject()
+void NeedsFinalizer::trace(Visitor* visitor)
{
- // Do something when destructed...
- (void)this;
+ A::trace(visitor);
}
-void HeapObject::trace(Visitor* visitor)
+void DoesNotNeedFinalizer::trace(Visitor* visitor)
{
- visitor->trace(m_obj);
+ A::trace(visitor);
}
}

Powered by Google App Engine
This is Rietveld 408576698