tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.txt - Issue 192933002: Check that classes with non-trivial destructors have finalization support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.txt

Issue 192933002: Check that classes with non-trivial destructors have finalization support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments and rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.txt ('k') | tools/clang/blink_gc_plugin/tests/heap/stubs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.txt

diff --git a/tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.txt b/tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.txt

index 042f66dc16d083b60bbd53552fe8cdbf81b3fbbe..762f03555f32d168a37c0e02c53f5cd52f667e11 100644

--- a/tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.txt

+++ b/tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.txt

@@ -1,4 +1,8 @@

-destructor_in_nonfinalized_class.cpp:9:1: warning: [blink-gc] Non-finalized class 'HeapObject' has a user-declared finalizer '~HeapObject'.

+In file included from destructor_in_nonfinalized_class.cpp:5:

+./destructor_in_nonfinalized_class.h:12:1: warning: [blink-gc] Non-finalized class 'HeapObject' requires finalization.

+class HeapObject : public GarbageCollected<HeapObject> {

+destructor_in_nonfinalized_class.cpp:9:1: note: [blink-gc] User-declared destructor declared here:

HeapObject::~HeapObject()

1 warning generated.