Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/clang/blink_gc_plugin/Config.h

Issue 192933002: Check that classes with non-trivial destructors have finalization support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments and rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp ('k') | tools/clang/blink_gc_plugin/Edge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/Config.h
diff --git a/tools/clang/blink_gc_plugin/Config.h b/tools/clang/blink_gc_plugin/Config.h
index 71b82ca43665f299f9a588a8ce0391552a037da2..c109a12a6406d7e3e4534a8a2ad00553afabeba3 100644
--- a/tools/clang/blink_gc_plugin/Config.h
+++ b/tools/clang/blink_gc_plugin/Config.h
@@ -73,6 +73,12 @@ class Config {
IsPersistentGCCollection(name);
}
+ static bool IsVector(const std::string& name) {
+ return name == "Vector" ||
+ name == "HeapVector" ||
+ name == "PersistentHeapVector";
+ }
+
static bool IsHashMap(const std::string& name) {
return name == "HashMap" ||
name == "HeapHashMap" ||
@@ -90,13 +96,13 @@ class Config {
static bool IsGCFinalizedBase(const std::string& name) {
return name == "GarbageCollectedFinalized" ||
- name == "RefCountedGarbageCollected";
+ name == "RefCountedGarbageCollected" ||
+ IsGCMixinBase(name);;
}
static bool IsGCBase(const std::string& name) {
return name == "GarbageCollected" ||
- IsGCFinalizedBase(name) ||
- IsGCMixinBase(name);
+ IsGCFinalizedBase(name);
}
static bool IsVisitor(const std::string& name) { return name == "Visitor"; }
« no previous file with comments | « tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp ('k') | tools/clang/blink_gc_plugin/Edge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698