tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.txt - Issue 192933002: Check that classes with non-trivial destructors have finalization support.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.txt

Issue 192933002: Check that classes with non-trivial destructors have finalization support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 destructor_in_nonfinalized_class.cpp:9:1: warning: [blink-gc] Non-finalized clas s 'HeapObject' has a user-declared finalizer '~HeapObject'.	1 In file included from destructor_in_nonfinalized_class.cpp:5:

	2 ./destructor_in_nonfinalized_class.h:12:1: warning: [blink-gc] Class 'HeapObject ' requires finalization.

	3 class HeapObject : public GarbageCollected<HeapObject> {

	4 ^

	5 destructor_in_nonfinalized_class.cpp:9:1: note: [blink-gc] User-declared destruc tor declared here:

2 HeapObject::~HeapObject()	6 HeapObject::~HeapObject()

3 ^	7 ^

4 1 warning generated.	8 1 warning generated.

OLD	NEW