tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.txt - Issue 192933002: Check that classes with non-trivial destructors have finalization support.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.txt

Issue 192933002: Check that classes with non-trivial destructors have finalization support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments and rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.cpp ('k') | tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 In file included from class_requires_finalization_field.cpp:5:

	2 ./class_requires_finalization_field.h:23:1: warning: [blink-gc] Non-finalized cl ass 'NeedsFinalizer' requires finalization.

	3 class NeedsFinalizer : public A {

	4 ^

	5 ./class_requires_finalization_field.h:27:5: note: [blink-gc] Field 'm_as' requir ing finalization declared here:

	6 Vector<Member<A> > m_as;

	7 ^

	8 ./class_requires_finalization_field.h:32:1: warning: [blink-gc] Non-finalized cl ass 'AlsoNeedsFinalizer' requires finalization.

	9 class AlsoNeedsFinalizer : public A {

	10 ^

	11 ./class_requires_finalization_field.h:36:5: note: [blink-gc] Field 'm_bs' requir ing finalization declared here:

	12 HeapVector<B, 10> m_bs;

	13 ^

	14 2 warnings generated.

OLD	NEW