Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1929323002: [build] Pull "build" from chromium as dependency (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Pull "build" from chromium as dependency BUG=chromium:474921 LOG=n R=jochen@chromium.org TBR=jkummerow@chromium.org, jochen@chromium.org Committed: https://crrev.com/4ecf8c64715140c2ea2a1b94b516c6d85bf86054 Cr-Commit-Position: refs/heads/master@{#35908}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -86 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +2 lines, -4 lines 0 comments Download
D build/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D build/shim_headers.gypi View 1 chunk +0 lines, -73 lines 0 comments Download
M gypfiles/OWNERS View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL. I'll land this manually as trybots can't test patches like this.
4 years, 7 months ago (2016-04-29 13:33:21 UTC) #3
Michael Achenbach
Compiles locally
4 years, 7 months ago (2016-04-29 13:34:04 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-04-29 13:36:35 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4ecf8c64715140c2ea2a1b94b516c6d85bf86054 Cr-Commit-Position: refs/heads/master@{#35908}
4 years, 7 months ago (2016-04-29 13:38:12 UTC) #8
Michael Achenbach
4 years, 7 months ago (2016-04-29 13:38:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4ecf8c64715140c2ea2a1b94b516c6d85bf86054 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698