Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/runtime/dart_sdk.js

Side-by-side diff isn't available for this file because of its large size.
Issue 1929283002: Fix for messed-up short-circuit operators. (Closed) Base URL: https://github.com/dart-lang/dev_compiler@master
Patch Set: rerun presumbit Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | lib/src/compiler/reify_coercions.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart_sdk.js
diff --git a/lib/runtime/dart_sdk.js b/lib/runtime/dart_sdk.js
index 12459d5a83dcf310438d7bf5179c7d1b73e08f02..3a8082b9fb3ee7871cdf2caed3cf4e7b382275f9 100644
--- a/lib/runtime/dart_sdk.js
+++ b/lib/runtime/dart_sdk.js
@@ -9083,8 +9083,8 @@ dart_library.library('dart_sdk', null, /* Imports */[
if (dart.notNull(dart.as(dart.dsend(i, '<=', 65535), core.bool))) {
a[dartx.add](dart.as(i, core.int));
} else if (dart.notNull(dart.as(dart.dsend(i, '<=', 1114111), core.bool))) {
- a[dartx.add](dart.asInt((55296)[dartx['+']](dart.as(dart.dsend(dart.dsend(dart.dsend(i, '-', 65536), '>>', 10), '&', 1023), core.num))));
- a[dartx.add](dart.asInt((56320)[dartx['+']](dart.as(dart.dsend(i, '&', 1023), core.num))));
+ a[dartx.add](dart.asInt(55296 + dart.notNull(dart.as(dart.dsend(dart.dsend(dart.dsend(i, '-', 65536), '>>', 10), '&', 1023), core.num))));
+ a[dartx.add](dart.asInt(56320 + dart.notNull(dart.as(dart.dsend(i, '&', 1023), core.num))));
} else {
dart.throw(new core.ArgumentError(i));
}
@@ -9106,8 +9106,8 @@ dart_library.library('dart_sdk', null, /* Imports */[
}
if (dart.notNull(dart.as(dart.dsend(charCode, '<=', 1114111), core.bool))) {
let bits = dart.dsend(charCode, '-', 65536);
- let low = (56320)[dartx['|']](dart.as(dart.dsend(bits, '&', 1023), core.int));
- let high = (55296)[dartx['|']](dart.as(dart.dsend(bits, '>>', 10), core.int));
+ let low = (56320 | dart.notNull(dart.as(dart.dsend(bits, '&', 1023), core.int))) >>> 0;
+ let high = (55296 | dart.notNull(dart.as(dart.dsend(bits, '>>', 10), core.int))) >>> 0;
return String.fromCharCode(high, low);
}
}
« no previous file with comments | « no previous file | lib/src/compiler/reify_coercions.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698