Issue 1929283002: Fix for messed-up short-circuit operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1929283002: Fix for messed-up short-circuit operators. (Closed)

Created:
4 years, 7 months ago by sra1

Modified:
4 years, 7 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	lib/runtime/dart_sdk.js	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
	M	lib/src/compiler/reify_coercions.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Leaf

I think you need to run the presubmit to re-generate the sdk js files. Otherwise ...

4 years, 7 months ago (2016-04-29 14:53:03 UTC) #3

sra1

4 years, 7 months ago (2016-04-29 18:57:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
961542eb96cd865dcf7eb1d8cca05022fb9fe283 (presubmit successful).