Added all the scoped_ptr -> unique_ptr commits to git blame ignore list.

Added all the scoped_ptr -> unique_ptr commits to git blame ignore list.

Also includes a commit in Blink replacing WebPassOwnPtr with unique_ptr.
All of these commits were written by one of the following authors:
dcheng, danakj, thakis, mostynb, jrummell, thestig.

This means git hyper-blame (in depot_tools) will stop blaming these
authors for all of the mechanical changes they made converting
scoped_ptr into std::unique_ptr throughout the codebase (and instead
those lines will be blamed on the previous author of that line).

BUG=554298
Committed: https://crrev.com/1a7fad99f9a1479c6b3063bc4207310a57f495b0
Cr-Commit-Position: refs/heads/master@{#391132}

[Matt Giuca, 2016-04-29 01:45:23]

mgiuca@chromium.org changed reviewers:
+ danakj@chromium.org, dcheng@chromium.org

[Matt Giuca, 2016-04-29 01:45:24]

dcheng, danakj: For review -- just to a) get your thoughts on whether this is
the right thing to do and b) quick skim the list of commits mentioned here to
check that I'm not including any non-mechanical changes. (I don't expect you to
check all the hashes.)
thakis: FYI (as co-owner of this file).

This list was generated by running:
git log --grep=std::unique_ptr --author=dcheng --author=danakj
--pretty=format:"# %s%n%H" >> .git-blame-ignore-revs
and then manually removing all the entries that didn't look mechanical (from the
commit description). I didn't manually verify that all the commits are
mechanical.

Context: A few months ago I wrote git-hyper-blame for pretty much this purpose:
so we can make sweeping renames like this without the authors of the rename
commits showing up in git blame everywhere. These are somewhat minor in that
your names will only show up on a few lines in each file, but I still think it's
worth it to blame the original authors of these lines. For example:

git blame
chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
16d15333 (bburns  2016-03-03 16:34:09 -0800  87)                       int64_t
offline_id);
03b1a6f7 (jianli  2016-02-26 17:57:41 -0800  88) 
aeceb05e (dcheng  2016-04-07 16:41:10 -0700  89)  
std::unique_ptr<TestNetworkChangeNotifier> network_change_notifier_;
03b1a6f7 (jianli  2016-02-26 17:57:41 -0800  90)   OfflinePageTabHelper*
offline_page_tab_helper_;  // Not owned.
03b1a6f7 (jianli  2016-02-26 17:57:41 -0800  91) 

(After this CL):
git hyper-blame
chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
16d15333 (bburns  2016-03-03 16:34:09 -0800   87)                       int64_t
offline_id);
03b1a6f7 (jianli  2016-02-26 17:57:41 -0800   88) 
03b1a6f7 (jianli  2016-02-26 17:57:41 -0800  89*)  
std::unique_ptr<TestNetworkChangeNotifier> network_change_notifier_;
03b1a6f7 (jianli  2016-02-26 17:57:41 -0800   90)   OfflinePageTabHelper*
offline_page_tab_helper_;  // Not owned.
03b1a6f7 (jianli  2016-02-26 17:57:41 -0800   91)

[Matt Giuca, 2016-04-29 01:46:57]

PS. If you can suggest another batch of scoped_ptr to unique_ptr commits I've
missed (e.g., another author that I didn't see was doing these), let me know. I
limited my search to just dcheng and danakj because listing all commits turned
up too much noise.

[danakj, 2016-04-29 01:49:18]

Wow thats a lot of CLs :) LGTM thanks

[Nico, 2016-04-29 01:50:25]

I did a few of these too, and jbroman a couple as well iirc
On Apr 28, 2016 9:49 PM, <danakj@chromium.org> wrote:

> Wow thats a lot of CLs :) LGTM thanks
>
> https://codereview.chromium.org/1929253002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Matt Giuca, 2016-04-29 01:51:10]

On 2016/04/29 01:49:18, danakj wrote:
> Wow thats a lot of CLs :) LGTM thanks

Yes, you guys have been quite busy (mostly dcheng)!

[danakj, 2016-04-29 01:57:21]

Going through https://bugs.chromium.org/p/chromium/issues/detail?id=554298
and searching "Author:" gives who else contributed.

mostynb@opera.com
jrummell@chromium.org
thakis@chromium.org
thestig@chromium.org

These 4 appear on the bug also.


On Thu, Apr 28, 2016 at 6:50 PM, Nico Weber <thakis@chromium.org> wrote:

> I did a few of these too, and jbroman a couple as well iirc
> On Apr 28, 2016 9:49 PM, <danakj@chromium.org> wrote:
>
>> Wow thats a lot of CLs :) LGTM thanks
>>
>> https://codereview.chromium.org/1929253002/
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Matt Giuca, 2016-04-29 03:36:50]

Great idea :)

I added the commits by thakis, mostynb, jrummell and thestig. I didn't add those
by jbroman because those looked like much more manual changes to GN (converting
raw pointers to unique_ptr; not just renaming scoped_ptr).

Interesting: the commit chain 42edb859 (initial land) -> 49964c23 (reverts it)
-> 7f767e65 (reland) needs all three of those commits to be listed; otherwise
all the lines last touched by 7f767e65 would be blamed on 49964c23 (the revert).

[Matt Giuca, 2016-04-29 03:39:11]

Description was changed from

==========
Added all the scoped_ptr -> unique_ptr commits to git blame ignore list.

This means git hyper-blame (in depot_tools) will stop blaming dcheng and
danakj for all of the mechanical changes they made converting scoped_ptr
into std::unique_ptr throughout the codebase (and instead those lines
will be blamed on the previous author of that line).

BUG=554298
==========

to

==========
Added all the scoped_ptr -> unique_ptr commits to git blame ignore list.

Also includes a commit in Blink replacing WebPassOwnPtr with unique_ptr.
All of these commits were written by one of the following authors:
dcheng, danakj, thakis, mostynb, jrummell, thestig.

This means git hyper-blame (in depot_tools) will stop blaming these
authors for all of the mechanical changes they made converting
scoped_ptr into std::unique_ptr throughout the codebase (and instead
those lines will be blamed on the previous author of that line).

BUG=554298
==========

[danakj, 2016-04-29 20:53:57]

On Thu, Apr 28, 2016 at 8:36 PM, <mgiuca@chromium.org> wrote:

> Great idea :)
>
> I added the commits by thakis, mostynb, jrummell and thestig. I didn't add
> those
> by jbroman because those looked like much more manual changes to GN
> (converting
> raw pointers to unique_ptr; not just renaming scoped_ptr).
>

Sounds good, thanks!

Interesting: the commit chain 42edb859 (initial land) -> 49964c23 (reverts
> it)
> -> 7f767e65 (reland) needs all three of those commits to be listed;
> otherwise
> all the lines last touched by 7f767e65 would be blamed on 49964c23 (the
> revert).
>
> https://codereview.chromium.org/1929253002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2016-04-29 20:54:03]

btw does the order in the file matter?

[Matt Giuca, 2016-05-01 23:49:23]

On 2016/04/29 20:54:03, danakj wrote:
> btw does the order in the file matter?

The order doesn't matter at all to the hyper-blame script (it puts them all into
a set before it does any processing). But just as a matter of housekeeping I
think it makes sense to keep the list in roughly chronological order. (I say
"roughly" because if someone was to, say, add a commit unrelated to
unique_ptrification that happens to fall in the given range, I'd probably put it
at the end of the block, just to keep all the commits related to a particular
refactoring effort together.) Ultimately it doesn't reall matter.

dcheng: Did you want to have a look at this as well?

[dcheng, 2016-05-02 19:01:54]

lgtm

[Matt Giuca, 2016-05-03 00:16:01]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-05-03 00:16:02]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1929253002/#ps40001
(title: "Added commits by thakis, mostynb, jrummell and thestig.")

[commit-bot: I haz the power, 2016-05-03 00:16:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929253002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929253002/40001

[commit-bot: I haz the power, 2016-05-03 00:57:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-03 00:58:40]

Description was changed from

==========
Added all the scoped_ptr -> unique_ptr commits to git blame ignore list.

Also includes a commit in Blink replacing WebPassOwnPtr with unique_ptr.
All of these commits were written by one of the following authors:
dcheng, danakj, thakis, mostynb, jrummell, thestig.

This means git hyper-blame (in depot_tools) will stop blaming these
authors for all of the mechanical changes they made converting
scoped_ptr into std::unique_ptr throughout the codebase (and instead
those lines will be blamed on the previous author of that line).

BUG=554298
==========

to

==========
Added all the scoped_ptr -> unique_ptr commits to git blame ignore list.

Also includes a commit in Blink replacing WebPassOwnPtr with unique_ptr.
All of these commits were written by one of the following authors:
dcheng, danakj, thakis, mostynb, jrummell, thestig.

This means git hyper-blame (in depot_tools) will stop blaming these
authors for all of the mechanical changes they made converting
scoped_ptr into std::unique_ptr throughout the codebase (and instead
those lines will be blamed on the previous author of that line).

BUG=554298

Committed: https://crrev.com/1a7fad99f9a1479c6b3063bc4207310a57f495b0
Cr-Commit-Position: refs/heads/master@{#391132}
==========

[commit-bot: I haz the power, 2016-05-03 00:58:41]

Patchset 3 (id:??) landed as
https://crrev.com/1a7fad99f9a1479c6b3063bc4207310a57f495b0
Cr-Commit-Position: refs/heads/master@{#391132}

[morelandn9, 2016-10-10 04:38:01]

On 2016/04/29 01:50:25, Nico wrote:
> I did a few of these too, and jbroman a couple as well iirc
> On Apr 28, 2016 9:49 PM, <mailto:danakj@chromium.org> wrote:
> 
> > Wow thats a lot of CLs :) LGTM thanks
> >
> > https://codereview.chromium.org/1929253002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

K