Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1929233002: ChromeRestriction for official build only. (Closed)

Created:
4 years, 7 months ago by BigBossZhiling
Modified:
4 years, 7 months ago
Reviewers:
Ted C, jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeRestriction for official build only. Created a ChromeRestriction, which restricts tests to be run only on official build. BUG=603983 Committed: https://crrev.com/768394859dc9a706ddd85178134843eb27026bac Cr-Commit-Position: refs/heads/master@{#390762}

Patch Set 1 #

Total comments: 1

Patch Set 2 : small fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java View 1 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeRestriction.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
BigBossZhiling
Tested the feature by adding RESTRICTION_TYPE_OFFICIAL_BUILD to a uiautomator testcase and the testcase is correctly ...
4 years, 7 months ago (2016-04-29 00:52:06 UTC) #3
jbudorick
looks fine, but you should add a test.
4 years, 7 months ago (2016-04-29 00:53:17 UTC) #4
BigBossZhiling
On 2016/04/29 00:53:17, jbudorick wrote: > looks fine, but you should add a test. In ...
4 years, 7 months ago (2016-04-29 01:23:59 UTC) #5
jbudorick
talked offline, this lgtm not an owner here, though, so +tedchoc
4 years, 7 months ago (2016-04-29 01:28:57 UTC) #7
Ted C
lgtm https://codereview.chromium.org/1929233002/diff/1/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java File chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java (right): https://codereview.chromium.org/1929233002/diff/1/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java#newcode78 chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java:78: ChromeRestriction.RESTRICTION_TYPE_OFFICIAL_BUILD) the indenting should be 8 from the ...
4 years, 7 months ago (2016-04-29 19:16:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929233002/20001
4 years, 7 months ago (2016-04-29 20:41:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 21:19:05 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:29:04 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/768394859dc9a706ddd85178134843eb27026bac
Cr-Commit-Position: refs/heads/master@{#390762}

Powered by Google App Engine
This is Rietveld 408576698