ChromeRestriction for official build only.

ChromeRestriction for official build only.

Created a ChromeRestriction, which restricts tests to be run only on
official build.

BUG=603983
Committed: https://crrev.com/768394859dc9a706ddd85178134843eb27026bac
Cr-Commit-Position: refs/heads/master@{#390762}

[BigBossZhiling, 2016-04-29 00:50:45]

Description was changed from

==========
ChromeRestriction for official build only.

Created a ChromeRestriction, which restricts tests to be run only on
official build.

BUG=603983
==========

to

==========
ChromeRestriction for official build only.

Created a ChromeRestriction, which restricts tests to be run only on
official build.

BUG=603983
==========

[BigBossZhiling, 2016-04-29 00:50:45]

hzl@google.com changed reviewers:
+ jbudorick@chromium.org

[BigBossZhiling, 2016-04-29 00:52:06]

Tested the feature by adding RESTRICTION_TYPE_OFFICIAL_BUILD to a uiautomator
testcase and the testcase is correctly skipped.

[jbudorick, 2016-04-29 00:53:17]

looks fine, but you should add a test.

[BigBossZhiling, 2016-04-29 01:23:59]

On 2016/04/29 00:53:17, jbudorick wrote:
> looks fine, but you should add a test.

In unofficial build, with no annotation,
hzl@hzl0:/usr/local/google/code/clankium4/src$
out-gn/Debug/bin/run_chrome_test_apk --test-filter
GservicesAndPackageNameBasedIdentificationGeneratorTest#testSuccessfullyGetAndUseAndroidId
C   12.420s Main 
********************************************************************************
C   12.421s Main  Summary
C   12.421s Main 
********************************************************************************
C   12.421s Main  [==========] 1 test ran.
C   12.421s Main  [  PASSED  ] 1 test.
C   12.421s Main 
********************************************************************************


Still in unofficial build, but after I add the only official build annotation.
hzl@hzl0:/usr/local/google/code/clankium4/src$
out-gn/Debug/bin/run_chrome_test_apk --test-filter
GservicesAndPackageNameBasedIdentificationGeneratorTest#testSuccessfullyGetAndUseAndroidId
C   19.291s Main 
********************************************************************************
C   19.291s Main  Summary
C   19.291s Main 
********************************************************************************
C   19.291s Main  [==========] 1 test ran.
C   19.291s Main  [  PASSED  ] 0 tests.
C   19.291s Main  [  SKIPPED ] Skipped 1 test, listed below:
C   19.291s Main  [  SKIPPED ]
com.google.android.apps.chrome.identity.GservicesAndPackageNameBasedIdentificationGeneratorTest#testSuccessfullyGetAndUseAndroidId
C   19.291s Main 
********************************************************************************

[jbudorick, 2016-04-29 01:28:56]

jbudorick@chromium.org changed reviewers:
+ tedchoc@chromium.org

[jbudorick, 2016-04-29 01:28:57]

talked offline, this lgtm

not an owner here, though, so +tedchoc

[Ted C, 2016-04-29 19:16:13]

lgtm

https://codereview.chromium.org/1929233002/diff/1/chrome/test/android/javates...
File
chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java
(right):

https://codereview.chromium.org/1929233002/diff/1/chrome/test/android/javates...
chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java:78:
ChromeRestriction.RESTRICTION_TYPE_OFFICIAL_BUILD)
the indenting should be 8 from the start of the previous row, the one above
isn't correct

[BigBossZhiling, 2016-04-29 20:41:34]

The CQ bit was checked by hzl@google.com

[BigBossZhiling, 2016-04-29 20:41:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1929233002/#ps20001
(title: "small fixes")

[commit-bot: I haz the power, 2016-04-29 20:41:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929233002/20001

[commit-bot: I haz the power, 2016-04-29 21:19:04]

Description was changed from

==========
ChromeRestriction for official build only.

Created a ChromeRestriction, which restricts tests to be run only on
official build.

BUG=603983
==========

to

==========
ChromeRestriction for official build only.

Created a ChromeRestriction, which restricts tests to be run only on
official build.

BUG=603983
==========

[commit-bot: I haz the power, 2016-04-29 21:19:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:29:04]

Patchset 2 (id:??) landed as
https://crrev.com/768394859dc9a706ddd85178134843eb27026bac
Cr-Commit-Position: refs/heads/master@{#390762}

[commit-bot: I haz the power, 2016-04-30 18:02:40]

Description was changed from

==========
ChromeRestriction for official build only.

Created a ChromeRestriction, which restricts tests to be run only on
official build.

BUG=603983
==========

to

==========
ChromeRestriction for official build only.

Created a ChromeRestriction, which restricts tests to be run only on
official build.

BUG=603983

Committed: https://crrev.com/768394859dc9a706ddd85178134843eb27026bac
Cr-Commit-Position: refs/heads/master@{#390762}
==========