chrome/chrome_browser.gypi - Issue 1929223002: Add skeletons for the factories to create the request coordinator and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1929223002: Add skeletons for the factories to create the request coordinator and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/offline_pages/request_coordinator_factory.cc ('K') | « chrome/browser/android/offline_pages/request_coordinator_factory.cc ('k') | components/offline_pages.gypi » ('j') | components/offline_pages/background/offliner_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index ddf6274335223a6b2679ab4047e3e7284c047b1b..a79d2a3386cbe11e700211e6c9fb37144586e8c6 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1558,12 +1558,18 @@

'browser/android/offline_pages/offline_page_tab_helper.h',

'browser/android/offline_pages/offline_page_utils.cc',

'browser/android/offline_pages/offline_page_utils.h',

+ 'browser/android/offline_pages/offliner.h',

fgorski 2016/05/03 22:48:16 according to UML the offliner interface should be

Pete Williamson 2016/05/04 00:39:21 Done. (Actually, it already is defined there, this

+ 'browser/android/offline_pages/offliner_factory.h',

'browser/android/offline_pages/prerendering_loader.cc',

'browser/android/offline_pages/prerendering_loader.h',

'browser/android/offline_pages/prerendering_offliner.cc',

'browser/android/offline_pages/prerendering_offliner.h',

+ 'browser/android/offline_pages/prerendering_offliner_factory.cc',

+ 'browser/android/offline_pages/prerendering_offliner_factory.h',

'browser/android/offline_pages/recent_tab_helper.cc',

'browser/android/offline_pages/recent_tab_helper.h',

+ 'browser/android/offline_pages/request_coordinator_factory.cc',

+ 'browser/android/offline_pages/request_coordinator_factory.h',

'chrome_browser_browser_process_sources': [

'browser/browser_process.cc',