Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 1929223002: Add skeletons for the factories to create the request coordinator and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Attempt gypi file fix. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_unittest.cc b/components/offline_pages/background/request_coordinator_unittest.cc
index c0388ce6c766dbde775291fec5996e51e138b421..28bd42774f0c9917b81a056724b04ca76b1424c8 100644
--- a/components/offline_pages/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_unittest.cc
@@ -4,8 +4,12 @@
#include "components/offline_pages/background/request_coordinator.h"
+#include <memory>
+#include <utility>
+
#include "base/bind.h"
-#include "base/memory/weak_ptr.h"
+#include "components/offline_pages/background/offliner_factory.h"
+#include "components/offline_pages/background/offliner_policy.h"
#include "components/offline_pages/background/save_page_request.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -37,12 +41,16 @@ TEST_F(RequestCoordinatorTest, StartProcessingWithNoRequests) {
base::Bind(
&RequestCoordinatorTest::CallbackFunction,
base::Unretained(this));
- RequestCoordinator coordinator;
+ std::unique_ptr<OfflinerPolicy> policy(new OfflinerPolicy());
+ std::unique_ptr<OfflinerFactory> factory;
+ RequestCoordinator coordinator(std::move(policy), std::move(factory));
EXPECT_FALSE(coordinator.StartProcessing(callback));
}
TEST_F(RequestCoordinatorTest, SavePageLater) {
- RequestCoordinator coordinator;
+ std::unique_ptr<OfflinerPolicy> policy(new OfflinerPolicy());
+ std::unique_ptr<OfflinerFactory> factory;
+ RequestCoordinator coordinator(std::move(policy), std::move(factory));
SavePageRequest request(kRequestId, kUrl, kClientId, base::Time::Now());
EXPECT_TRUE(coordinator.SavePageLater(request));
}

Powered by Google App Engine
This is Rietveld 408576698