Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 1929223002: Add skeletons for the factories to create the request coordinator and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR fixes per DougArnett and FGorski Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator.cc
diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc
index 1e4d25633666f742df462f8cb8cd67a28b347030..21ed6c99ddecca18cff90c35608811fd716d909b 100644
--- a/components/offline_pages/background/request_coordinator.cc
+++ b/components/offline_pages/background/request_coordinator.cc
@@ -5,16 +5,20 @@
#include "components/offline_pages/background/request_coordinator.h"
// TODO(fgorski): include file with SavePageRequest definition.
fgorski 2016/05/04 05:20:58 I think you can resolve the TODO now.
Pete Williamson 2016/05/04 21:23:21 Done, also moved added the save_page_request.h inc
+#include "components/offline_pages/background/offliner_policy.h"
namespace offline_pages {
-// TODO(dougarnett): How to inject Offliner factories and policy objects.
-RequestCoordinator::RequestCoordinator() {
+RequestCoordinator::RequestCoordinator(
+ OfflinerPolicy* policy, OfflinerFactory* factory) {
// Do setup as needed.
+ // TODO(petewil): Assert policy not null.
+ policy_ = policy;
+ factory_ = factory;
}
RequestCoordinator::~RequestCoordinator() {
- // Do cleanup as needed.
+ delete policy_;
}
bool RequestCoordinator::SavePageLater(const SavePageRequest& request) {

Powered by Google App Engine
This is Rietveld 408576698