Add skeletons for the factories to create the request coordinator and

components/offline_pages/background/offliner_factory.h

+// Copyright 2015 The Chromium Authors. All rights reserved.

[fgorski, 2016/04/29 04:16:46]

2016

[Pete Williamson, 2016/05/02 20:51:14]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_FACTORY_H_
+#define COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_FACTORY_H_
+
+#include "base/macros.h"
+#include "components/offline_pages/background/offliner_factory.h"

[fgorski, 2016/04/29 04:16:46]

I think you are trying to include this file.

[Pete Williamson, 2016/05/02 20:51:14]

Done.

+
+namespace base {
+template <typename T>
+struct DefaultSingletonTraits;

[fgorski, 2016/04/29 04:16:46]

Why is this included?

[Pete Williamson, 2016/05/02 20:51:14]

Leftover from cut-and-paste.  Removed.

+}  // namespace base
+
+namespace offline_pages {
+
+class OfflinerPolicy;
+class Offliner;
+
+// A factory to create one unique OfflinePageModel.

[fgorski, 2016/04/29 04:16:46]

update to refer to the right class.

Explain the ownership model for the created Offliners, after which you may
update the signature of GetInstance to unique_ptr

[Pete Williamson, 2016/05/02 20:51:14]

Updated.  I chose not to return a unique_ptr since we might cache the Offliner
in the factory to avoid creating it multiple times.

+class OfflinerFactory {
+ public:
+  virtual Offliner* GetInstance(OfflinerPolicy* policy);

[fgorski, 2016/04/29 04:16:46]

GetInstance sounds more like a singleton. Did you consider different name?

e.g. GetOffliner, MakeOffliner?


Also, why is policy passed by pointer?

[Pete Williamson, 2016/05/02 20:51:14]

Changed to GetOffliner.

I didn't want to make a copy, and was hazy on when references are allowed. 
Would you prefer a reference?  Would you prefer some flavor of smart pointer?

+
+  OfflinerFactory() {}
+  virtual ~OfflinerFactory() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(OfflinerFactory);
+};
+
+}  // namespace offline_pages
+
+#endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_FACTORY_H_