Add skeletons for the factories to create the request coordinator and

components/offline_pages/background/request_coordinator.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_COORDINATOR_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_COORDINATOR_H_
 
 #include "base/callback.h"
+#include "components/keyed_service/core/keyed_service.h"
+#include "components/offline_pages/background/save_page_request.h"

[fgorski, 2016/05/04 05:20:58]

I think you can forward declare this one.

[Pete Williamson, 2016/05/04 21:23:21]

Done.

 
 namespace offline_pages {
 
+class OfflinerPolicy;
+class OfflinerFactory;
+class Offliner;
+
 // Coordinates queueing and processing save page later requests.
-class RequestCoordinator {
+class RequestCoordinator : public KeyedService {

[fgorski, 2016/05/04 05:20:58]

Did you consider adding DISALLOW... at the end?

[Pete Williamson, 2016/05/04 21:23:21]

Done.

  public:
   // Callback to report when the processing of a triggered task is complete.
   typedef base::Callback<void()> ProcessingDoneCallback;
 
-  struct SavePageRequest {
-    // TODO(dougarnett): define and consider making stand-alone.
-  };
 
-  // TODO(dougarnett): How to inject Offliner factories and policy objects.
-  RequestCoordinator();
+  RequestCoordinator(
+      OfflinerPolicy* policy, OfflinerFactory* factory);

[fgorski, 2016/05/04 05:20:58]

To clearly communicate ownership you should probably pass these using unique_ptr
using std::move.

See:
https://code.google.com/p/chromium/codesearch#chromium/src/components/offline...
for example of that.

[Pete Williamson, 2016/05/04 21:23:21]

Done.

 
-  ~RequestCoordinator();
+  ~RequestCoordinator() override;
 
   // Queues |request| to later load and save when system conditions allow.
   bool SavePageLater(const SavePageRequest& request);
 
   // Starts processing of one or more queued save page later requests.
   // Returns whether processing was started and that caller should expect
   // a callback. If processing was already active, returns false.
   bool StartProcessing(const ProcessingDoneCallback& callback);
 
   // Stops the current request processing if active. This is a way for
   // caller to abort processing; otherwise, processing will complete on
   // its own. In either case, the callback will be called when processing
   // is stopped or complete.
   void StopProcessing();
 
-  // TODO(dougarnett): add policy support methods.
+ private:
+  OfflinerPolicy* policy_;
+  // Factory ownership is taken over here.
+  OfflinerFactory* factory_;
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_COORDINATOR_H_