[full-codegen] Fix stack depth tracking when reporting unsupported super usages

[full-codegen] Fix stack depth tracking when reporting unsupported super usages

Also mark VisitSuperCallReference as unreachable, as it's handled by VisitCall.

R=mstarzinger@chromium.org
BUG=v8:4967
LOG=n

Committed: https://crrev.com/567aa1be6d8d873fe544b112865eb94688fc6130
Cr-Commit-Position: refs/heads/master@{#35945}

[Michael Starzinger, 2016-04-29 07:52:49]

LGTM. Thanks! The interpreter seems to print a different stacktrace though
judging from the try jobs.

[adamk, 2016-04-29 17:52:39]

On 2016/04/29 07:52:49, Michael Starzinger wrote:
> LGTM. Thanks! The interpreter seems to print a different stacktrace though
> judging from the try jobs.

Hmm, for some reason the interpreter is using an inferred name while
full-codegen is not. Given that this is unrelated to what I'm trying to fix (a
CHECK failure in full-codegen), I'm inclined to simply make this not a message
test. Let me know what you think (next patchset will move the test to
mjsunit/regress/)

[adamk, 2016-04-29 17:57:34]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 17:57:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929213002/20001

[commit-bot: I haz the power, 2016-04-29 18:19:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 18:19:52]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-05-02 08:07:18]

On 2016/04/29 17:52:39, adamk wrote:
> On 2016/04/29 07:52:49, Michael Starzinger wrote:
> > LGTM. Thanks! The interpreter seems to print a different stacktrace though
> > judging from the try jobs.
> 
> Hmm, for some reason the interpreter is using an inferred name while
> full-codegen is not. Given that this is unrelated to what I'm trying to fix (a
> CHECK failure in full-codegen), I'm inclined to simply make this not a message
> test. Let me know what you think (next patchset will move the test to
> mjsunit/regress/)

Works for me. I filed an issue on the bug tracker:

https://bugs.chromium.org/p/v8/issues/detail?id=4980

[adamk, 2016-05-02 17:04:13]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-05-02 17:04:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1929213002/#ps20001
(title: "Move test out of message/")

[commit-bot: I haz the power, 2016-05-02 17:04:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929213002/20001

[commit-bot: I haz the power, 2016-05-02 17:28:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-02 17:29:01]

Description was changed from

==========
[full-codegen] Fix stack depth tracking when reporting unsupported super usages

Also mark VisitSuperCallReference as unreachable, as it's handled by VisitCall.

R=mstarzinger@chromium.org
BUG=v8:4967
LOG=n
==========

to

==========
[full-codegen] Fix stack depth tracking when reporting unsupported super usages

Also mark VisitSuperCallReference as unreachable, as it's handled by VisitCall.

R=mstarzinger@chromium.org
BUG=v8:4967
LOG=n

Committed: https://crrev.com/567aa1be6d8d873fe544b112865eb94688fc6130
Cr-Commit-Position: refs/heads/master@{#35945}
==========

[commit-bot: I haz the power, 2016-05-02 17:29:02]

Patchset 2 (id:??) landed as
https://crrev.com/567aa1be6d8d873fe544b112865eb94688fc6130
Cr-Commit-Position: refs/heads/master@{#35945}