Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: ash/root_window_controller.h

Issue 1929203002: mash: Fix crash when clicking on the shelf overflow icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/shelf/overflow_bubble.cc » ('j') | ash/system/tray/tray_background_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/root_window_controller.h
diff --git a/ash/root_window_controller.h b/ash/root_window_controller.h
index 517de7f6d9b21ea81d085aef6cedb6a49bd883d2..6a9773d177465125be2f086b7f686934862dfbba 100644
--- a/ash/root_window_controller.h
+++ b/ash/root_window_controller.h
@@ -77,6 +77,10 @@ class AshTouchExplorationManager;
// The RootWindowController for particular root window is stored in
// its property (RootWindowSettings) and can be obtained using
// |GetRootWindowController(aura::WindowEventDispatcher*)| function.
+//
+// NOTE: In classic ash there is one RootWindow per display, so every RootWindow
+// has a RootWindowController. In mus/mash there is one RootWindow per Widget,
msw 2016/04/28 23:57:36 q: Is it one per top-level widget?
James Cook 2016/04/29 16:17:40 Yep, one per top-level widget. Updated.
+// so not all RootWindows have a RootWindowController.
class ASH_EXPORT RootWindowController : public ShellObserver {
public:
// Creates and Initialize the RootWindowController for primary display.
« no previous file with comments | « no previous file | ash/shelf/overflow_bubble.cc » ('j') | ash/system/tray/tray_background_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698