mash: Fix crash when clicking on the shelf overflow icon

mash: Fix crash when clicking on the shelf overflow icon

Under mus/mash, each widget has its own RootWindow. Only the RootWindow for
the display has a RootWindowController. OverflowBubble was attempting to look
up the display's RootWindowController from the shelf's widget, which doesn't
have one.

There is a separate problem that prevents the overflow bubble from showing
(it immediately closes due to a focus/activation issue) but with this CL at
least we don't crash on click.

We'll need to audit other callers of RootWindowController::ForWindow() to
ensure they are safe; I'll file a bug for that.

BUG=595851
TEST=Run mash, launch some apps, resize window to get overflow icon to show,
click icon, no crash.

Committed: https://crrev.com/2a5ffa2195e262691da5d7bab4ac1364622cfcde
Cr-Commit-Position: refs/heads/master@{#390690}

[James Cook, 2016-04-28 23:40:23]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-04-28 23:40:24]

msw, please take a look

[msw, 2016-04-28 23:57:36]

lgtm with nit and q

https://codereview.chromium.org/1929203002/diff/1/ash/root_window_controller.h
File ash/root_window_controller.h (right):

https://codereview.chromium.org/1929203002/diff/1/ash/root_window_controller....
ash/root_window_controller.h:82: // has a RootWindowController. In mus/mash
there is one RootWindow per Widget,
q: Is it one per top-level widget?

https://codereview.chromium.org/1929203002/diff/1/ash/system/tray/tray_backgr...
File ash/system/tray/tray_background_view.cc (right):

https://codereview.chromium.org/1929203002/diff/1/ash/system/tray/tray_backgr...
ash/system/tray/tray_background_view.cc:271: bubble_widget->GetNativeWindow(),
optional nit: cache this

[James Cook, 2016-04-29 16:17:39]

jamescook@chromium.org changed reviewers:
+ oshima@chromium.org

[James Cook, 2016-04-29 16:17:40]

oshima, can I get OWNERS for //ash ?

https://codereview.chromium.org/1929203002/diff/1/ash/root_window_controller.h
File ash/root_window_controller.h (right):

https://codereview.chromium.org/1929203002/diff/1/ash/root_window_controller....
ash/root_window_controller.h:82: // has a RootWindowController. In mus/mash
there is one RootWindow per Widget,
On 2016/04/28 23:57:36, msw wrote:
> q: Is it one per top-level widget?

Yep, one per top-level widget. Updated.

https://codereview.chromium.org/1929203002/diff/1/ash/system/tray/tray_backgr...
File ash/system/tray/tray_background_view.cc (right):

https://codereview.chromium.org/1929203002/diff/1/ash/system/tray/tray_backgr...
ash/system/tray/tray_background_view.cc:271: bubble_widget->GetNativeWindow(),
On 2016/04/28 23:57:36, msw wrote:
> optional nit: cache this

Done.

[oshima, 2016-04-29 16:58:15]

lgtm

[James Cook, 2016-04-29 17:28:25]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-04-29 17:28:26]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/1929203002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-29 17:28:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1929203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1929203002/40001

[commit-bot: I haz the power, 2016-04-29 17:44:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:26:57]

Patchset 3 (id:??) landed as
https://crrev.com/2a5ffa2195e262691da5d7bab4ac1364622cfcde
Cr-Commit-Position: refs/heads/master@{#390690}

[commit-bot: I haz the power, 2016-04-30 18:01:20]

Description was changed from

==========
mash: Fix crash when clicking on the shelf overflow icon

Under mus/mash, each widget has its own RootWindow. Only the RootWindow for
the display has a RootWindowController. OverflowBubble was attempting to look
up the display's RootWindowController from the shelf's widget, which doesn't
have one.

There is a separate problem that prevents the overflow bubble from showing
(it immediately closes due to a focus/activation issue) but with this CL at
least we don't crash on click.

We'll need to audit other callers of RootWindowController::ForWindow() to
ensure they are safe; I'll file a bug for that.

BUG=595851
TEST=Run mash, launch some apps, resize window to get overflow icon to show,
click icon, no crash.
==========

to

==========
mash: Fix crash when clicking on the shelf overflow icon

Under mus/mash, each widget has its own RootWindow. Only the RootWindow for
the display has a RootWindowController. OverflowBubble was attempting to look
up the display's RootWindowController from the shelf's widget, which doesn't
have one.

There is a separate problem that prevents the overflow bubble from showing
(it immediately closes due to a focus/activation issue) but with this CL at
least we don't crash on click.

We'll need to audit other callers of RootWindowController::ForWindow() to
ensure they are safe; I'll file a bug for that.

BUG=595851
TEST=Run mash, launch some apps, resize window to get overflow icon to show,
click icon, no crash.

Committed: https://crrev.com/2a5ffa2195e262691da5d7bab4ac1364622cfcde
Cr-Commit-Position: refs/heads/master@{#390690}
==========