third_party/protobuf/README.chromium - Issue 1929193002: Use offsetof in ZR_HELPER_ for Clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/README.chromium

Issue 1929193002: Use offsetof in ZR_HELPER_ for Clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/protobuf/README.chromium

diff --git a/third_party/protobuf/README.chromium b/third_party/protobuf/README.chromium

index 3453b849bf94369d40a42eed6515330974bc042f..0a46b30e6159fd15539e44cc085fc8242bcf1e2b 100644

--- a/third_party/protobuf/README.chromium

+++ b/third_party/protobuf/README.chromium

@@ -87,3 +87,9 @@ Description of the patches:

These patches uninline some functions, resulting in a significant reduction

(somewhere between 500 KB and 1 MB) of binary size.

+- 0011-use-offsetof-for-clang.patch

+ This patch replaces a few invalid reinterpret_casts with __builtin_offsetof,

+ if compiled with Clang. This is a temporary patch, it should be deletd, when

+ the official github repo is updates with this changes already submitted to

+ the internal Google repo.

xyzzyz 2016/04/28 23:42:56 Please link to the issue on github, so that we kno

« no previous file with comments | « no previous file | third_party/protobuf/patches/0011-use-offsetof-for-clang.patch » ('j') | no next file with comments »