Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1929163004: Revert of PaymentRequest shipping address labels. (Closed)

Created:
4 years, 7 months ago by mdjones
Modified:
4 years, 7 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of PaymentRequest shipping address labels. (patchset #1 id:20001 of https://codereview.chromium.org/1937563002/ ) Reason for revert: Compile broken on clang-clankium-tot-builder and instrumentation-mako-clankium-tot. (AutofillDialogControllerImpl.java calls getProfiles()) Original issue's description: > PaymentRequest shipping address labels. > > The PaymentRequest UI should show the shipping address on two lines: > > LABEL: The address on a single line without the name of the recipient. > SUB-LABEL: The name of the recipient. > > BUG=607971 TBR=dfalcantara@chromium.org,mathp@chromium.org,rouslan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607971 Committed: https://crrev.com/142b98e4d3b296b478eb5e549edb3ab2797a5f52 Cr-Commit-Position: refs/heads/master@{#390803}

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
mdjones
Created Revert of PaymentRequest shipping address labels.
4 years, 7 months ago (2016-04-29 23:41:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929163004/1
4 years, 7 months ago (2016-04-29 23:41:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 23:42:10 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:30:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/142b98e4d3b296b478eb5e549edb3ab2797a5f52
Cr-Commit-Position: refs/heads/master@{#390803}

Powered by Google App Engine
This is Rietveld 408576698