Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1929143003: [qcms] Use a static table in build_output_lut to invert para curves (Closed)

Created:
4 years, 7 months ago by Noel Gordon
Modified:
4 years, 7 months ago
Reviewers:
radu, radu.velea
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[qcms] Use a static table in build_output_lut to invert para curves Instead of allocating the uint16_t output table, use a static table gamma_table_uint[256], to match the code in compute_precache(). Minor: adjust the fprintf text in the qcms_tests_output_trc test to clarify the test output. TBR=radu.velea@intel.com BUG=600338 Committed: https://crrev.com/df1527ec51ed0079b792b260340918c9abfe551c Cr-Commit-Position: refs/heads/master@{#390583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M third_party/qcms/README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/qcms/src/tests/qcms_test_output_trc.c View 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/qcms/src/transform_util.c View 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Noel Gordon
4 years, 7 months ago (2016-04-29 01:06:19 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929143003/1
4 years, 7 months ago (2016-04-29 01:06:53 UTC) #5
Noel Gordon
Compare with the compute_precache() code: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/qcms/src/transform_util.c&q=build_output_lut%20compute_precache&sq=package:chromium&type=cs&l=516 Running the test: ./qcms_tests.exe -t qcms_test_output_trc -i itu-bt709.icc Test ...
4 years, 7 months ago (2016-04-29 01:18:01 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 02:18:18 UTC) #8
Noel Gordon
Will TBR for now, Radu please review when you have time.
4 years, 7 months ago (2016-04-29 02:44:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1929143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1929143003/1
4 years, 7 months ago (2016-04-29 02:45:08 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-29 02:48:47 UTC) #14
radu
On 2016/04/29 02:48:47, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) lgtm
4 years, 7 months ago (2016-04-29 06:28:31 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:24:04 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df1527ec51ed0079b792b260340918c9abfe551c
Cr-Commit-Position: refs/heads/master@{#390583}

Powered by Google App Engine
This is Rietveld 408576698